Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let RegularSurface.compare_topology() allow a precision level #1257

Open
jcrivenaes opened this issue Oct 21, 2024 · 0 comments
Open

Let RegularSurface.compare_topology() allow a precision level #1257

jcrivenaes opened this issue Oct 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jcrivenaes
Copy link
Collaborator

With regards to:

def compare_topology(self, other, strict=True):

The comparison of e.g. xori, yori requires now an exact match. However, there may be numerical differences, or it may be that the user
requires a more lose match for some reasons.

The proposal is to add an absolute tolerance, like

def compare_topology(self, other, strict=True, abs=0.1)

In this case, abs=0.01 will mean that an xori value of 450000 will allow a range 449999.09 to 450000.1

Possibly also consider a relative tolerance.

@jcrivenaes jcrivenaes added the enhancement New feature or request label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant