Skip to content

S3 name is still static (Issue 10) #38

@AstroTom

Description

@AstroTom

(Issue #10) is still a problem.

The S3 bucket name is constant e.g. terminator-test-bucket-<account> (e.g. terminator-test-bucket-637423315357)
So after a cleanup, it cannot be created again for hours.
Also, cannot run tests in 2 regions at once since the S3 bucket name is global.

There is a parameter 'EnvironmentName' in the CFN, but it seems not to be used in the scripts and always defaults to terminator-test.

I added the following to line 55 test/scripts/deploy-test-infra.sh and that seemed to fix it.

    --parameters ParameterKey=EnvironmentName,ParameterValue=terminator-test-$SUFFIX 

like this:

# Deploy stack
 50 aws cloudformation "$OPERATION" \
 51     --stack-name "$STACK_NAME" \
 52     --template-body "file://$TEMPLATE_FILE" \
 53     --capabilities CAPABILITY_NAMED_IAM \
 54     --region "$REGION" \
 55     --parameters ParameterKey=EnvironmentName,ParameterValue=terminator-test-$SUFFIX \
 56     --tags Key=Project,Value=termiNATor Key=Environment,Value=test

It seems there is some confusion about reusing the same stack name vs the S3 name. As it is saved in test/results/stack-name.txt

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions