Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] disable unused default metrics #928

Open
1 task
ashnamehrotra opened this issue Dec 12, 2023 · 3 comments
Open
1 task

[REQ] disable unused default metrics #928

ashnamehrotra opened this issue Dec 12, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@ashnamehrotra
Copy link
Contributor

What kind of request is this?

None

What is your request or suggestion?

disable unused default metrics: https://github.com/eraser-dev/eraser/blob/main/main.go#L100

Are you willing to submit PRs to contribute to this feature request?

  • Yes, I am willing to implement it.
@ashnamehrotra ashnamehrotra added the enhancement New feature or request label Dec 12, 2023
@sozercan sozercan added this to the v1.4.0 milestone Dec 14, 2023
@salaxander salaxander added the good first issue Good for newcomers label Feb 7, 2024
@sozercan sozercan modified the milestones: v1.4.0, v1.5.0 Nov 11, 2024
@Burnleydev1
Copy link

Hello @sozercan @salaxander I am new here and I am willing to contribute to this project, can you please assign this issue to me?

@Burnleydev1
Copy link

please I have been facing this specific error when I run make run

docker run --rm -v /home/burnley/eraser/eraser:/eraser eraser-tooling controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./api/..."
docker run --rm -v /home/burnley/eraser/eraser:/eraser eraser-tooling conversion-gen \
        --output-base=/eraser \
        --input-dirs=./api/v1alpha1,./api/v1,./api/v1alpha2,./api/v1alpha3 \
        --go-header-file=./hack/boilerplate.go.txt \
        --output-file-base=zz_generated.conversion
go fmt ./...
go vet ./...
go run ./main.go
{"level":"error","ts":1734431937.165126,"logger":"setup","msg":"aborting","error":"config file was not supplied","stacktrace":"main.main\n\t/home/burnley/eraser/eraser/main.go:134\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:272"}
exit status 1
make: *** [Makefile:215: run] Error 1

@ashnamehrotra
Copy link
Contributor Author

@Burnleydev1 what go version is this running on and is this the current main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants