-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we really need the revert as a particular case? #175
Comments
Just to clarify. During the workshop which took place on 19-20 February I discussed with UBologna the revert and we concluded that the scenario should be corrected. Nothing was secret, in particular testing sessions done at that time were aware. Scenario was corrected immediately after my return home and the new Excel file was posted with the date 2024-03-01, the 1st of March. The log inside the Excel file contains the list of changes, in particular I do not see any previous changes to revert.
I do not see on the list any test reports signed before the workshop in Thessaloniki.
Scenarios are only for those who consider them useful. No obligation to be read by the others. |
The Workshop is a useful and interesting moment, but what is said there is not an official communication that something, included in the specifications is changed or, better, is going to change.
You cannot expect that someone looks through almost 1710 cells (3x30x19) to see what of them has changed in a relevant way! Moreover, thanks to the assumption that after a single approval we have a new mutual approval, become useless al scenarios with action after a single approval, because they become a similar scenario that simply restarts from the first row. Less scenarios = less cells to look through do discover the relevant part changed
The new scenario file was published on 4th march, 2024; we can rely on it only from that date, before we cannot know how you could have formalized what you have concluded during the workshop.
Not so exactly. |
The specification has not changed. |
Could you kindly show me where the specifications define the following aspects, recalled by the scenarios:
But they don't explain why for the same action (B approves, row 14, scenario 11) we have now a different behavior and A cannot revert anymore (row 16 and 17). |
Since something has gone wrong during the testing session on revert, we have asked @janinamincer-daszkiewicz and I discovered that she changed again the revert scenarios after the workshop in Thessaloniki.
Therefore, now I learnt that:
The need for the revert has been justified so: "DG EAC saying many times that what they want to avoid on a business level is to force approvals which are not needed."
But if we consider that now should be commonly accepted that the Approval API must return always the last approved IIA Hash, it's clear that the "revert" doesn't require any extra approval if considered as a normal amendment:
I show hereafter all the scenarios, in a short way (avoiding CNR, Get and so on step by step, that are needed anyway).
There isn't any step that requires a not needed approval on a business level just to satisfy the revert on a technical level if managed as a normal amendment. If there is, please show me where.
On my opinion, the revert should be excluded from the testing sessions, and the saved time used to test more critical function to avoid issues like the empty index or the wrong IIA hash in the approval response.
Scenarios when both of the partners start to modify before reverting (you can imagine it as a second amendment)
Scenarios when only one of the partners start to modify before reverting (you can imagine it as a second amendment)
Since the scenarios changed after the 4th march, 2024, what about all the testing session concluded before that date?
It's not a question if I like or not the scenarios, the point is if we can reduce the number of scenarios and particularly the number of useless tests, that carry only delays or errors in triggering something in the test environment.
The text was updated successfully, but these errors were encountered: