Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage to 80% #159

Open
Nezteb opened this issue May 29, 2023 · 2 comments
Open

Increase test coverage to 80% #159

Nezteb opened this issue May 29, 2023 · 2 comments

Comments

@Nezteb
Copy link

Nezteb commented May 29, 2023

Describe the bug
As part of adding ergo to awesome-go, the repo needs to have at least 80% test coverage, which it currently does not.

Current test coverage: coverage.zip

❯ cat coverage.html | grep '<option value="file' | sed -E 's/.*>(.*) \((.*)%\)<.*/\2 \1/' | sort -rn

89.2 github.com/ergo-services/ergo/etf/encode.go
65.8 github.com/ergo-services/ergo/etf/etf.go
56.2 github.com/ergo-services/ergo/lib/mpsc.go
51.0 github.com/ergo-services/ergo/etf/decode.go
43.8 github.com/ergo-services/ergo/etf/cache.go
12.7 github.com/ergo-services/ergo/proto/dist/proto.go
8.3 github.com/ergo-services/ergo/lib/tools.go
0.0 github.com/ergo-services/ergo/proto/dist/registrar.go
0.0 github.com/ergo-services/ergo/proto/dist/handshake.go
0.0 github.com/ergo-services/ergo/proto/dist/flusher.go
0.0 github.com/ergo-services/ergo/proto/dist/epmd.go
0.0 github.com/ergo-services/ergo/lib/cert.go
@halturin
Copy link
Collaborator

Thanks for the report.
I had no plan to reach this level of coverage, especially for the 2.* version. But in 3.* I'm expecting to improve it. (3.0 version is planned to release this fall)

@Nezteb
Copy link
Author

Nezteb commented May 29, 2023

Yeah 80% is a lot, especially for a long-existing project to suddenly achieve. I only posted this to track the progress, as awesome-go is pretty strict about the 80% coverage mark. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants