Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use outerHeight and account for padding, margins, border #37

Open
ergophobe opened this issue Aug 30, 2013 · 1 comment
Open

Use outerHeight and account for padding, margins, border #37

ergophobe opened this issue Aug 30, 2013 · 1 comment

Comments

@ergophobe
Copy link

.simplemodal-container is the same height as simplemodal-wrap, but that means that if the CSS applies margin, borders or padding and you have long content that scrolls, the modal is bigger than the window.

So the height should be window height - (margin + border + padding)

As a simple check, outerHeight should be <= window height.

@ergophobe
Copy link
Author

er... sorry outerHeight(true) should be <= window height

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant