Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted bound check in SimdMemoryStream.h #280

Open
T8902 opened this issue Dec 22, 2024 · 1 comment
Open

Inverted bound check in SimdMemoryStream.h #280

T8902 opened this issue Dec 22, 2024 · 1 comment

Comments

@T8902
Copy link

T8902 commented Dec 22, 2024

In the file SimdMemoryStream.h there are multiple while loops which are unsafe due to the check order.
This is also reported in CVE-2024-3207 indirectly, since I believe this is where the bug described there is caused by.

An example of such unsafe check would be on line 199 of the file:
while ( !IsGap(_data[_pos]) && _pos < _size )
this should be:
while ( _pos < _size && !IsGap(_data[_pos]))
I have a branch which fixed all of them, however I don't have the correct rights to push anything.

@ermig1979
Copy link
Owner

Hi! Thank you for bug report. I will check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants