Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SASS deprecation warning when updating to latest sass #83

Open
JaroCamphuijsen opened this issue Nov 19, 2024 · 1 comment
Open

SASS deprecation warning when updating to latest sass #83

JaroCamphuijsen opened this issue Nov 19, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file

Comments

@JaroCamphuijsen
Copy link
Collaborator

When we update SASS to the latest version, it will start raising many deprecation warnings. Partly they are from the assets/nlesc-decorations.scss file. But the majority comes from reveal.js which has not been updated for the new sass behaviour.

As of #71, the reveal.js and sass versions have been pinned down to avoid these warnings.

Once reveal.js is updated, we should also bump the version of reveal in NEBULA and update the sass version.
@JaroCamphuijsen
Copy link
Collaborator Author

Issue in reveal.js: hakimel/reveal.js#3718

@JaroCamphuijsen JaroCamphuijsen added the dependencies Pull requests that update a dependency file label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JaroCamphuijsen