Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting filter_pred and stream_management=true breaks automatic SM #207

Open
erszcz opened this issue Apr 5, 2019 · 1 comment
Open

Setting filter_pred and stream_management=true breaks automatic SM #207

erszcz opened this issue Apr 5, 2019 · 1 comment

Comments

@erszcz
Copy link
Member

erszcz commented Apr 5, 2019

The problem happens at least in case of escalus_tcp transport due to escalus_connection:maybe_forward_to_owner running the filter before escalus_tcp:forward_to_owner, which extracts SM elements intended for automatic handling. In other words, the filter might filter out SM <r/> elements, which ought to be handled by escalus_tcp. This problem occurred when trying to run an AMOC scenario with SM enabled, but the filter set to only allow messages:

escalus_connection:set_filter_predicate(Client, fun escalus_pred:is_message/1)
@erszcz
Copy link
Member Author

erszcz commented Apr 5, 2019

This seems to be a duplicate of #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erszcz