Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a 'message' option for no-restricted-disable #157

Open
JoshuaKGoldberg opened this issue Dec 11, 2023 · 2 comments
Open

Allow a 'message' option for no-restricted-disable #157

JoshuaKGoldberg opened this issue Dec 11, 2023 · 2 comments

Comments

@JoshuaKGoldberg
Copy link

JoshuaKGoldberg commented Dec 11, 2023

Could we specify rules as objects containing the and a custom message as a property? That way users can be told more explicitly why a rule shouldn't be disabled:

module.exports = {
	// ...
	rules: {
		"@eslint-community/eslint-comments/no-restricted-disable": [
			"error",
			{
				rules: [
					{
						message: "Explanation for why this is so.",
						rule: "rule-to-never-disable",
					},
				],
			},
		],
	},
	// ...
};

Aside: I went through the process of writing https://github.com/JoshuaKGoldberg/eslint-plugin-never-disable because I'd missed that eslint-plugin-eslint-comments/no-restricted-disable is under the Stylistic section of https://mysticatea.github.io/eslint-plugin-eslint-comments 🤦. Sigh.

@github-actions github-actions bot added the Stale label Feb 9, 2024
Copy link

This issue has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from issues that aren't actionable. Please reach out if you have more information for us! 🙂

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2024
@JoshuaKGoldberg
Copy link
Author

JoshuaKGoldberg commented Feb 17, 2024

Err. No. This just never was triaged 😞 ...

cc @ota-meshi - is the stalebot intended to be this aggressive?

Edit: #164

@ota-meshi ota-meshi reopened this Feb 18, 2024
@ota-meshi ota-meshi removed the Stale label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants