Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint-plugin-vue's disable comments #212

Open
FloEdelmann opened this issue Apr 23, 2024 · 1 comment
Open

Support eslint-plugin-vue's disable comments #212

FloEdelmann opened this issue Apr 23, 2024 · 1 comment

Comments

@FloEdelmann
Copy link

In Vue Single File Components (*.vue files), "HTML comments" can be used to disable ESLint rules: https://eslint.vuejs.org/rules/comment-directive.html

<template>
  <!-- eslint-disable-next-line vue/max-attributes-per-line -->
  <div a="1" b="2" c="3" d="4" />
</template>

Unfortunately, those comments are not detected by eslint-plugin-eslint-comments.

(Note: This issue is the same as #136, which was auto-closed as stale without a warning, but is still relevant.)

@GrantGryczan
Copy link

GrantGryczan commented Nov 15, 2024

This applies to CSS, SCSS, etc. linting in Vue too, by the way.

<template></template>

<style scoped>
/* eslint-disable-next-line vue-scoped-css/require-selector-used-inside */
.unused {
  filter: brightness(0);
}
</style>

<style scoped lang="scss">
// eslint-disable-next-line vue-scoped-css/require-selector-used-inside
.also-unused {
  filter: brightness(0);
}
</style>

This should, but currently doesn't, warn for the missing reasons on both eslint-disable comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants