feat(rule): add no-identity-handlers rule #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't think to check for object or array destructuring - will include those test cases and rule additions in a future commit. getObject().then(({ a, b }) => ({ a, b }))
getArray().then(([a, b]) => [a, b]) |
macklinu
force-pushed
the
rule/no-identity-handlers
branch
from
af77254
to
38c7191
Compare
|
I've addressed the object and array destructuring. I would like to consider better |
macklinu
force-pushed
the
rule/no-identity-handlers
branch
2 times, most recently
from
bc8c3d9
to
4a350ec
Compare
|
Pushed up a couple of failing test cases that need to be addressed - hadn't thought through those edge cases. |
This was referenced Feb 25, 2018
macklinu
force-pushed
the
rule/no-identity-handlers
branch
from
4a350ec
to
e6de9fd
Compare
macklinu
force-pushed
the
rule/no-identity-handlers
branch
from
e6de9fd
to
ebe5b93
Compare
macklinu
force-pushed
the
rule/no-identity-handlers
branch
from
ebe5b93
to
3963ab8
Compare
|
I opened this months ago and even I don't understand the code I wrote. 😅 Aiming to readdress this PR in the coming week or so. |
|
This is pretty outdated, and I'd like to take a different approach moving forward, so will close and open a new PR some other time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
This PR implements and resolves #12. It checks to see if the
then()orcatch()callback functions are identity functions. For our purposes, an identity function is:I would like to flesh out the documentation for this before merging, but opening a PR in case anyone has suggestions for a better rule name or code cases I haven't considered.