Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: warn for returned promises that swallow errors #128

Open
dbkaplun opened this issue May 21, 2018 · 0 comments
Open

Feature: warn for returned promises that swallow errors #128

dbkaplun opened this issue May 21, 2018 · 0 comments

Comments

@dbkaplun
Copy link

Hello,

It would be great if promises in this form triggered a warning:

function foo() {
  return bar()
    .then(...)
    .catch((err) => {
      console.error(err);
    });
}

Rather than trying to prevent the user from swallowing errors entirely, the goal is to ensure errors are only swallowed intentionally:

function foo() {
  return bar()
    .then(...)
    .catch((err) => { // eslint-disable-line promise/no-swallow-error-in-returned-promise
      console.error(err);
    });
}

Thanks for considering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants