-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codemod for v8 -> v9 rule API changes #25
Comments
I'm wondering if we need this project anymore, because |
Maybe, but creating a dependency on ESLint in order to fix plugins that aren't working in ESLint might cause issues. I think updating this tool to have something standalone is beneficial at least in the near term. |
But okay, I'm not opposed to updating this tool as well. |
How should we handle |
We should create a codemod that applies most of the changes mentioned in the blog post about changes to the rule API. Primarily changing:
context.getScope()
context.markVariableAsUsed()
context.getAncestors()
context.getDeclaredVariables()
For each of these, we should be creating backwards-compatible code such as:
We should also update references to the methods listed in this section
If we find a reference to
CodePath#currentSegments
, then the best thing to do is output a warning stating that it can't be fixed automatically and point to this section.(It probably can be fixed automatically but would be pretty complicated. If we get enough requests then we can revisit.)
The text was updated successfully, but these errors were encountered: