Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install python3 and python3-venv. #404

Closed
r12f opened this issue Dec 10, 2023 · 3 comments
Closed

Install python3 and python3-venv. #404

r12f opened this issue Dec 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@r12f
Copy link

r12f commented Dec 10, 2023

Motivations

When following the esp-idf-template to setup the example repo, the new repo might fail to be build, because ESP-IDF requires python3-venv to be installed.

However, installing the step of installing python-venv is not listed in either esp-idf-template or Rust on ESP book. And it can be easily missed.

  • Would you like to implement this feature? [n]

Solution

I feel making espup installing python and python-venv as part of frequently used dependency might make sense and will be helpful.

Alternatives

Updating both Rust on ESP book and esp-idf-template README should also work.

Additional context

@r12f r12f added the enhancement New feature or request label Dec 10, 2023
@SergioGasquez
Copy link
Member

I feel like the alternative solution is more clean, since:

  1. It's way simpler to just suggest the user to install them, we do not need to worry of which OS is he running and if he has any conflicts with those packages
  2. espup does not install ESP-IDF and has nothing to do with it, no_std user do not require python and I would like to keep it this way.

I agree that book and esp-idf-template can be updated to include them, though.

@r12f
Copy link
Author

r12f commented Dec 11, 2023

Hi Sergio, makes sense! And thanks a lot for checking! I believe the issue can be closed now.

@SergioGasquez
Copy link
Member

SergioGasquez commented Dec 11, 2023

Just noticed that the book already includes those, in the last line of https://esp-rs.github.io/book/installation/std-requirements.html and for the template we have https://github.com/esp-rs/esp-idf-template/tree/master?tab=readme-ov-file#install-python3

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants