Skip to content

Inactive code block not working correctly (IEP-1500) #1191

@mmrein

Description

@mmrein

Describe the bug

Apart that LSP editor makes inactive code block look like comment, which looses its syntax higlhight and therefore makes multi-target builds much harder, it can even be straight up wrong.

Screenshots

I made myself some core affinity setup indication so I can see it at one place without needing to run sdkconfig and searching through various components.

This is how it looked in IDE v2.12 - you can see which configuration is active and which is not:

Image

And this is same setup with IDE v3.3:

Image

Steps to reproduce

You can try adding this or simillar code to you project and build it:

/* ESP System Settings / Main task core affinity */
#if defined CONFIG_ESP_MAIN_TASK_AFFINITY_NO_AFFINITY	// Main task has affinity
#elif defined CONFIG_ESP_MAIN_TASK_AFFINITY_CPU0		// Main task set to Core 0
#elif defined CONFIG_ESP_MAIN_TASK_AFFINITY_CPU1		// Main task set to Core 1
#endif
/* WiFi / WiFi task */		
#if defined CONFIG_ESP32_WIFI_TASK_PINNED_TO_CORE_0		// WiFi task set to Core 0
#elif defined CONFIG_ESP32_WIFI_TASK_PINNED_TO_CORE_1	// WiFi task set to Core 1
#endif
/* MDF Common / MDF task */
#if defined CONFIG_MDF_PINNED_TO_CORE_0					// MDF task set to Core 0
#elif defined CONFIG_MDF_PINNED_TO_CORE_1				// MDF task set to Core 1
#endif
/* LWIP / TCPIP task affinity */
#if defined CONFIG_LWIP_TCPIP_TASK_AFFINITY_NO_AFFINITY	// TCPIP task has affinity
#elif defined CONFIG_LWIP_TCPIP_TASK_AFFINITY_CPU0		// TCPIP task set to Core 0
#elif defined CONFIG_LWIP_TCPIP_TASK_AFFINITY_CPU1		// TCPIP task set to Core 1
#endif
/* mDNS task - may be used with webpages */
#if defined CONFIG_MDNS_TASK_AFFINITY_NO_AFFINITY		// mDNS task has affinity
#elif defined CONFIG_MDNS_TASK_AFFINITY_CPU0			// mDNS task set to Core 0
#elif defined CONFIG_MDNS_TASK_AFFINITY_CPU1			// mDNS task set to Core 1
#endif

Expected behavior

Clear and correct distinction between active and inactive code block, preferably by change of background color of whole block while keeping original syntax highlight.

Espressif-IDE Product Information:

espprodinf.txt

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions