-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Example of Multiple Writes in a Single Transaction to 'How to make multiple writes in a transaction' Tutorial #901
Comments
Thanks for raising this @romainwg - I agree that page could certainly have some more comprehensive examples. We should also replicate the change across to the 3.6 version page https://etcd.io/docs/v3.6/tutorials/how-to-transactional-write. If you have time to propose a pull request please give it a try. I am happy to answer any questions and provide feedback 🙏🏻 |
I'll give this a go! I will make a pr today or tmrw. I wanted to know how the gifs are uploaded to google store. @jmhbnz |
ectd_transaction2.mp4I have this gif showing two examples, one with updating/writing to multiple keys and the second trying two writes to the same transaction and failing |
Hi, @NavinShrinivas. The images from the website are embedded in the repository. You can
After surveying the repository, I don't think there's a standard, so either way should work. |
Noted! Did the changes in the pr. handled lint too. awaiting your feedback :) |
…tion to tutorial see: etcd-io#901
Sorry for the delay, here's what I did: #908 |
…tion to tutorial see: etcd-io#901 Signed-off-by: Romain WALCH--GUINEBERT <[email protected]>
…tion to tutorial see: etcd-io#901 Signed-off-by: Romain WALCH--GUINEBERT <[email protected]>
Hi @romainwg and @NavinShrinivas. I reviewed both of your pull requests. I wouldn't say that one is correct (or better than the other one). But it definitely adds contention to resolve this issue. Given that technically this wasn't assigned to anybody, and that @romainwg originally opened the issue, I would suggest to:
Ideally, I would prefer a single pull request (1). But let me know your thoughts. |
Thank you @ivanvc I don't want to sound pretentious, but I think our proposals are orthogonal. On #908:
(And it may be too big for just one PR, but it's simpler for me.) Also, when I posted the issue I had already started thinking about the best way to illustrate the transaction documentation. If it makes things easier for the maintainers, I'll commit to the first PR, but my changes are quite different... |
Current Title of the Web Page: How to make multiple writes in a transaction
Feedback:
I noticed that the current example on the page primarily demonstrates the structure of transactions using
if
,then
,else
, andcommit
statements. However, it does not include an example of making multiple writes within a single transaction.To enhance the technical clarity and usefulness of this tutorial, I suggest adding an example (or modifying the existing one) to explicitly show how to perform multiple writes in a single transaction. Demonstrating a batch of operations would be particularly beneficial for users looking to understand this functionality better. For instance, an example that includes multiple
Put
operations within a single transaction would be very helpful.Thank you for considering this improvement.
The text was updated successfully, but these errors were encountered: