Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra templates #3

Open
etewiah opened this issue Jan 2, 2017 · 13 comments
Open

Add extra templates #3

etewiah opened this issue Jan 2, 2017 · 13 comments

Comments

@etewiah
Copy link
Owner

etewiah commented Jan 2, 2017

I would like to add between 15 and 30 templates to give users a choice of how their websites will look.

Right now I am working on adding this template created by Md. Altaf Hossain under the MIT license:

http://www.markups.io/items/home-property-free-real-estate-website-template

Many thanks to him for making his template freely available. I would recommend him as someone to contact for anyone requiring a custom theme.

Please feel free to recommend any templates you come across that you would like added, particularly templates with a license that allows reuse in an open source project.

@etewiah
Copy link
Owner Author

etewiah commented Mar 10, 2017

I currently have a solution for theming which needs a bit more testing before it is rolled out. It works by having different folders located here for each theme:

https://github.com/etewiah/property_web_builder/tree/master/app/themes

In the application_controller I have a set_theme_path method that reads the “theme_name” value for the current agency.
It then uses prepend_view_path to add the theme path to the list of locations that rails will check for a template. The best explanation of how prepend_view_path works can be found here:

http://climber2002.github.io/blog/2015/04/06/digging-rails-how-rails-finds-your-templates-part-4/

The set_theme_path method also sets the self.class.layout value.

Until I implement an admin page section for changing themes, the easiest way to experiment with the themes feature is to run the following from the rails console:

agency = Pwb::Agency.unique_instance
agency.theme_name = "berlin"
agency.save!

@etewiah
Copy link
Owner Author

etewiah commented Apr 15, 2017

I have implemented an experimental ui for changing the theme. Have a look here if you are interested:

https://propertywebbuilder.herokuapp.com/en/admin/website/themes/default

@mmikeww
Copy link

mmikeww commented Aug 11, 2017

Looks like that template is offline as of today. Maybe the guy is updating his site

Archive page here, but download link doesn't work:

https://web.archive.org/web/20161119032944/http://www.markups.io:80/items/home-property-free-real-estate-website-template/

@etewiah
Copy link
Owner Author

etewiah commented Aug 11, 2017

Hi @mmikeww, I've actually implemented that theme. I just need to test it and make sure it works well. Are you willing to help with this?

@mmikeww
Copy link

mmikeww commented Aug 11, 2017

Sure, can you put it up on the demo site so I can click around?

@etewiah
Copy link
Owner Author

etewiah commented Aug 11, 2017

It is the Berlin theme which you can set from here:

https://propertywebbuilder.herokuapp.com/en/admin/website/themes/default

I have just now set the demo site to the Berlin theme.

@mmikeww
Copy link

mmikeww commented Aug 12, 2017

It looked fine to me.. Was there something in particular you wanted me to test?

One thing I noticed, but not theme specific, is that it seems on your other re-renting.com site, on the buy/rent pages, there are extra fields to filter a search with. But on the pwb.herokuapp.com demo site, the search fields are more limited

@etewiah
Copy link
Owner Author

etewiah commented Aug 12, 2017

Okay, its good everything works for you. I did some small customisations for the re-renting site which I will put into the main project soon.

BTW, I'm doing a survey to try to understand what things to prioritise so would be good if you can give some feedback here:

https://goo.gl/forms/xQkvBKmE1p8PUhzn1

@acsmartinho
Copy link

acsmartinho commented Nov 15, 2017 via email

@etewiah
Copy link
Owner Author

etewiah commented Nov 15, 2017

Ruby on Rails cannot be installed with ftp. If you are not familiar with installing ruby on rails then use heroku.
In the readme there is a big purple button with the text "deploy to heroku" - just click it and follow the instructions.
If you encounter any problems please open a new issue. This issue is specifically about adding extra templates.

@acsmartinho
Copy link

Ok i saw that button but in the heroku you can use your own domain? in the example i just saw something like domain.heroku.com

@etewiah
Copy link
Owner Author

etewiah commented Nov 16, 2017

Hi @acsmartinho , I realise you're new to github so this is some friendly advice. When you have a question please open a new issue. This issue is about themes so everyone who is participating will get notifications when you mention something. It is not nice for them to get notifications when you are asking about something not related to themes.

It is very easy to open issues. Here is an issue I just opened with your question (and an answer).
#39

Repository owner deleted a comment from acsmartinho Dec 25, 2017
@etewiah
Copy link
Owner Author

etewiah commented Mar 14, 2018

I've decided to change the approach to theming. I am now working on implementing themes as Vue.js / vuetify frontends. The project for this is here:

https://github.com/etewiah/pwb-themes-base

This makes it super easy to adapt the front end which will talk to the rails server via API calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants