Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatePlugin.sh doesn't update plugins #6670

Open
brunob opened this issue Sep 19, 2024 · 3 comments
Open

updatePlugin.sh doesn't update plugins #6670

brunob opened this issue Sep 19, 2024 · 3 comments

Comments

@brunob
Copy link
Contributor

brunob commented Sep 19, 2024

Running bin/updatePlugin.sh script doesn't update plugins. My test instance was using 0.174 of ep_markdown plugins and the script didn't detect it.

The only way i've found to update a plugin was to desinstall/reinstall it from admin page.

Is there another way to know if plugins update are available and to perform upgrades ?

@SamTV12345
Copy link
Member

Thanks for the issue. For now you can remove and reinstall a plugin that should suffice. The updatePlugin.sh did the same just in one step.

@brunob
Copy link
Contributor Author

brunob commented Oct 4, 2024

Thx for the feedback, so maybe we should fix the script here https://github.com/ether/etherpad-lite/blob/develop/bin/updatePlugins.sh#L11 to do exec exec pnpm remove "$@" && pnpm install "$@" instead of exec pnpm install "$@" ?

@SamTV12345
Copy link
Member

Thx for the feedback, so maybe we should fix the script here https://github.com/ether/etherpad-lite/blob/develop/bin/updatePlugins.sh#L11 to do exec exec pnpm remove "$@" && pnpm install "$@" instead of exec pnpm install "$@" ?

Or maybe we should use the new command. pnpm plugins rm <plugin> and pnpm plugins install <plugin> ? Feel free to create a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@brunob @SamTV12345 and others