installation of @resvg/resvg-js & satori dependencies

[jasongitmail]

In 1.2.3, @ethercorps/sveltekit-og now requires the installation of @resvg/resvg-js and satori separately.

What build errors does that solve? I'm curious to learn to help brainstorm an alternate approach because it would seem to be a more ideal user experience if those were installed as dependencies (ideally) or at least peer dependencies.

[theetherGit]

By mistake in last version i forgot to mention to install the peer-dependency. That's all, i made mistakes in last version so currently i'm focusing on my mistakes i made and fixing them.

And this time i was checking for something and by mistake i replaced peer-dependency by dependency.

I'm working on a basic docs, so i'll be clearing all the issues before releasing it.

@jasongitmail can you help me with docs?

[theetherGit]

@jasongitmail should i change dependency to peer dependency? I think this will resolve this query

[jasongitmail]

What do you have in mind? I thought your current docs seemed sufficient, with the excellent Quickstart section. The only thing I'd suggest is to start with Installation and Quickstart sections and move the Changelog below those.

[jasongitmail]

I can submit a PR to help reorganize it a bit. You can tweak it over time. Personally I wouldn't worry much about a separate docs site, but your call.

[theetherGit]

Well it's not seperate docs, i do have other sveltekit related library and i'm thinking of providing docs for that too.

sveltekit-redis-session

[theetherGit]

B/w for now if possible can you do the tweaks in the readme? if you can i'll have some time to focus and also be a guide for official docs too.

[jasongitmail]

Yep, I submitted a PR to refactor the README. #14 Should be a good first start and we can keep improving it from here.

[theetherGit]

Thank you so much.

[jasongitmail]

FWIW, @ethercorps/sveltekit-og v1.2.3 still works for me without requiring separate installation of @resvg/resvg-js and satori. I ran npm uninstall @ethercorps/sveltekit-og && npm i -D @ethercorps/sveltekit-og to confirm. Personally I like it this way, it's a good user experience.

[theetherGit]

Ok, IDK why it didn't work on mine.

Which adapter are you using?

[jasongitmail]

Good question. import adapter from '@sveltejs/adapter-cloudflare';

[theetherGit]

Ok I'll look into it. It's already too late, i'll check more on it tomorrow.

[theetherGit]

vercel build doesn't have any issues only node adapter causing this.

[theetherGit]

In 1.2.3, @ethercorps/sveltekit-og now requires the installation of @resvg/resvg-js and satori separately.

What build errors does that solve? I'm curious to learn to help brainstorm an alternate approach because it would seem to be a more ideal user experience if those were installed as dependencies (ideally) or at least peer dependencies.

If you have some more ideas please let me and work on it together.