Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimism config values to inflight PRs adding chains #532

Closed
geoknee opened this issue Aug 29, 2024 · 0 comments · Fixed by #536
Closed

Add optimism config values to inflight PRs adding chains #532

geoknee opened this issue Aug 29, 2024 · 0 comments · Fixed by #536
Assignees

Comments

@geoknee
Copy link
Collaborator

geoknee commented Aug 29, 2024

Since #510 , we store more information in chain config toml files. But PRs created before that change will not have those fields.

I propose we write a test which requires the fields exist (we can do this via the Go bindings, although they will use default values for the non pointer types, so 0 for uints). Then PRs will be forced to add the data before being merged to main:

Most chains will just add:

[optimism]
  eip1559_elasticity = 6
  eip1559_denominator = 50
  eip1559_denominator_canyon = 250

Perhaps we could use any config validation helpers from op-geth to check the values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants