You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since #510 , we store more information in chain config toml files. But PRs created before that change will not have those fields.
I propose we write a test which requires the fields exist (we can do this via the Go bindings, although they will use default values for the non pointer types, so 0 for uints). Then PRs will be forced to add the data before being merged to main:
Since #510 , we store more information in chain config toml files. But PRs created before that change will not have those fields.
I propose we write a test which requires the fields exist (we can do this via the Go bindings, although they will use default values for the non pointer types, so 0 for
uints
). Then PRs will be forced to add the data before being merged to main:Most chains will just add:
Perhaps we could use any config validation helpers from op-geth to check the values?
The text was updated successfully, but these errors were encountered: