You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The rewards tests use a BeaconState in epoch 0, which isn't compatible with implementations that avoid processing rewards in the genesis epoch.
The process_rewards_and_penalties function does not compute rewards in epoch 0:
defprocess_rewards_and_penalties(state: BeaconState) ->None:
# No rewards are applied at the end of `GENESIS_EPOCH` because rewards are for work done in the previous epochifget_current_epoch(state) ==GENESIS_EPOCH:
return
...
In Lighthouse, while moving to single-pass epoch processing we no longer have code for computing individual deltas, and extract the deltas (actually the sum of all deltas) from our single-pass implementation. Single-pass epoch processing (correctly) skips rewards calculations in epoch 0.
The text was updated successfully, but these errors were encountered:
It seems there's actually only 1 rewards test with the genesis epoch, the empty case:
Test Result
Title: altair/rewards/basic
11 tests, 0 failed, 1 skipped (known failure), 0 skipped (bls), 10 passed. (See below for errors)
-------
case () from /home/michael/Programming/lighthouse3/testing/ef_tests/consensus-spec-tests/tests/mainnet/altair/rewards/basic/pyspec_tests/empty skipped because it's a known failure
The
rewards
tests use aBeaconState
in epoch 0, which isn't compatible with implementations that avoid processing rewards in the genesis epoch.The
process_rewards_and_penalties
function does not compute rewards in epoch 0:https://github.com/ethereum/consensus-specs/blob/v1.4.0-beta.6/specs/altair/beacon-chain.md#rewards-and-penalties
In Lighthouse, while moving to single-pass epoch processing we no longer have code for computing individual deltas, and extract the deltas (actually the sum of all deltas) from our single-pass implementation. Single-pass epoch processing (correctly) skips rewards calculations in epoch 0.
The text was updated successfully, but these errors were encountered: