Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with the text on the 'previous' button on the EVM opcodes page. #13405

Open
1 of 2 tasks
UNOFFICIALbgd opened this issue Jul 16, 2024 · 5 comments · May be fixed by #13523 or #14811
Open
1 of 2 tasks

Issues with the text on the 'previous' button on the EVM opcodes page. #13405

UNOFFICIALbgd opened this issue Jul 16, 2024 · 5 comments · May be fixed by #13523 or #14811
Assignees
@jenish-thapa
Labels
bug 🐛 Something isn't working design required 🎨 This involves design changes design system this label will be used in all issues related to design system design All the issues related to design should use this tag Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@UNOFFICIALbgd
Copy link
Contributor

Describe the bug

  1. Text came out of the box in Russian (and maybe in some other languages).
  2. Text touches the underline, which doesn't look good.

To reproduce

  1. Go to 'ethereum.org/en/developers/docs/evm/opcodes/'
  2. Scroll down to 'previous' button
  3. See error

Expected behavior

Maybe we can make the text of the button wider?

Screenshots

image
Text touches the underline, which doesn't look good.

image
Text came out of the box in Russian (and maybe in some other languages).

Desktop (please complete the following information)

Windows, chrome

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@UNOFFICIALbgd UNOFFICIALbgd added the bug 🐛 Something isn't working label Jul 16, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jul 16, 2024
@wackerow
Copy link
Member

To my knowledge we have an updated version of this component in the design system. Personally would love to just see that one inmplemented as a more sustainable fix here. cc: @nloureiro do we have plans for this component to be implemented?

@wackerow wackerow added question ❓ Further information is requested design required 🎨 This involves design changes design All the issues related to design should use this tag design system this label will be used in all issues related to design system and removed needs triage 📥 This issue needs triaged before being worked on labels Jul 16, 2024
@nloureiro
Copy link
Contributor

To my knowledge we have an updated version of this component in the design system. Personally would love to just see that one inmplemented as a more sustainable fix here. cc: @nloureiro do we have plans for this component to be implemented?

yes, this is a known problem

I have this on the Design system if someone wants to implement ;)

Screen Shot 2024-07-16 02 52 54 PM

https://www.figma.com/design/NrNxGjBL0Yl1PrNrOT8G2B/ethereum.org-Design-System?node-id=5452-60878&t=GBI9TtaUGLYa8wRF-1

@jenish-thapa
Copy link

jenish-thapa commented Jul 28, 2024 •
edited
Loading

Hey @nloureiro and @wackerow,

I saw that you need a button designed according to the Figma file. I’d like to contribute by taking on this task. Could you please assign it to me?

@wackerow wackerow removed the question ❓ Further information is requested label Jul 28, 2024
@wackerow
Copy link
Member

Thanks @jenish-thapa! Assigned

@jenish-thapa jenish-thapa linked a pull request Jul 28, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 27, 2024
iusx added a commit to iusx/ethereum-org-website that referenced this issue Feb 2, 2025
@iusx
fix: ethereum#13405 and end ethereum#13523 use shadcn
bf0cd33
@iusx iusx linked a pull request Feb 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenish-thapa jenish-thapa

Labels
bug 🐛 Something isn't working design required 🎨 This involves design changes design system this label will be used in all issues related to design system design All the issues related to design should use this tag Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
No milestone
4 participants
@nloureiro @wackerow @UNOFFICIALbgd @jenish-thapa