Skip to content

Conversation

@0x0Glitch
Copy link

@0x0Glitch 0x0Glitch commented Apr 20, 2025

This PR addresses three separate issues:

  1. Fixed typos in error messages:

    • Changed "cant" to "can't"
    • Fixed "form a stateless view" to "from a stateless view"
    • Fixed "statless" to "stateless"
  2. improved error handling:

    • Added missing sentinel error variables to doc.go
    • Modified implementations to use these central error variables
    • Enables proper error checking with errors.Is() throughout the codebase
  3. Fixed O(N²) DoS vulnerability in proof_ipa.go:

    • Added keyStemIndex map for efficient lookups
    • Replaced linear scans with map lookups in 3 locations for optimizing performance
    • Changed performance from O(N²) to O(N) for large proofs(it will prevent DOS)
image

@0x0Glitch
Copy link
Author

Hello @gballet,please have a look at the third point(Fixed O(N²) DoS vulnerability in proof_ipa.go) if that optimizes the performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant