Skip to content

When moving LearnEth to the right side or to the left panel, it refreshes #4945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryestew opened this issue Jul 1, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working refactoring/coding style

Comments

@ryestew
Copy link
Collaborator

ryestew commented Jul 1, 2024

Describe the bug
LearnEth doesn't keep its state when moving from the left side panel to the right side panel.

Is this typical of all plugins or just learnEth?

@ryestew ryestew added the bug Something isn't working label Jul 1, 2024
@ryestew ryestew assigned ioedeveloper and joeizang and unassigned ioedeveloper Jul 1, 2024
@joeizang
Copy link
Collaborator

joeizang commented Jul 2, 2024

@ioedeveloper would be in the best position to answer this question with any authority. But I suspect LearnEth needs to be refactored so that its state gets updated when it is moved to the right side panel

@drafish
Copy link
Contributor

drafish commented Jul 4, 2024

I think it's typical of all iframe plugins. I tried etherscan, same issue. @ryestew

@joeizang joeizang assigned ioedeveloper and unassigned joeizang Aug 22, 2024
@github-project-automation github-project-automation bot moved this to Next Release in Backlog Aug 27, 2024
@LianaHus LianaHus added the discussion Require discussion label Feb 24, 2025
@LianaHus LianaHus added refactoring/coding style and removed discussion Require discussion labels Mar 26, 2025
@bunsenstraat
Copy link
Collaborator

It depends on how you store the state as a plugin. The iframe plugin itself cannot handle that. It's in the plugin code. But that said, none of our plugins keep state on reloads.

@github-project-automation github-project-automation bot moved this from Next Release to Closed in Backlog Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring/coding style
Projects
Status: Closed
Development

No branches or pull requests

6 participants