Skip to content

Scriptrunner as main plugin#5652

Merged
joeizang merged 20 commits intomasterfrom
scriptrunnermain
Feb 17, 2025
Merged

Scriptrunner as main plugin#5652
joeizang merged 20 commits intomasterfrom
scriptrunnermain

Conversation

@bunsenstraat
Copy link
Copy Markdown
Collaborator

@bunsenstraat bunsenstraat commented Jan 16, 2025

Scriptrunner should be moved from side panel to mainview bu ux team request. This is a refactoring that needed to start to work on the UI. (Liana)

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 16, 2025

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit f061c76
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/67b2fba94b56510008729dcd
😎 Deploy Preview https://deploy-preview-5652--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bunsenstraat bunsenstraat changed the title Scriptrunnermain Scriptrunner as main plugin Jan 16, 2025
}

focus (name) {
console.log('focus', name)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

this.on('manager', 'pluginActivated', ({ name, location, displayName, icon, description }) => {

if (location === 'mainPanel') {
console.log('pluginActivated', name, location, displayName, icon, description)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this?

@joeizang joeizang requested a review from LianaHus February 17, 2025 11:27
Copy link
Copy Markdown
Contributor

@LianaHus LianaHus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concole.logs we will cleanup after review with Filip

@joeizang joeizang merged commit b05df60 into master Feb 17, 2025
@joeizang joeizang deleted the scriptrunnermain branch February 17, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants