Skip to content
This repository was archived by the owner on Jul 1, 2021. It is now read-only.

Commit dfd036b

Browse files
committed
tests: mark some upstream tests xfail.
This is almost a copy of what's in py-evm's `master` ATM; the difference is likely due to the fact that trinity's using a tagged package of py-evm, so probably doesn't get the latest fixes yet. TODO: Remove this duplication of INCORRECT_UPSTREAM_TESTS; perhaps extend it in trinity if there's something specific.
1 parent 2716cda commit dfd036b

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

tests/json-fixtures-over-rpc/test_rpc_fixtures.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,23 @@
115115
# The result is in conflict with the yellow-paper:
116116
# * https://github.com/ethereum/py-evm/pull/1224#issuecomment-418800369
117117
('GeneralStateTests/stRevertTest/RevertInCreateInInit_d0g0v0.json', 'RevertInCreateInInit_d0g0v0_Byzantium'), # noqa: E501
118+
('GeneralStateTests/stRevertTest/RevertInCreateInInit_d0g0v0.json', 'RevertInCreateInInit_d0g0v0_Constantinople'), # noqa: E501
119+
120+
# The CREATE2 variant seems to have been derived from the one above - it, too,
121+
# has a "synthetic" state, on which py-evm flips.
122+
# * https://github.com/ethereum/py-evm/pull/1181#issuecomment-446330609
123+
('GeneralStateTests/stCreate2/RevertInCreateInInitCreate2_d0g0v0.json', 'RevertInCreateInInitCreate2_d0g0v0_Constantinople'), # noqa: E501
124+
125+
# Four variants have been specifically added to test a collision type
126+
# like the above; therefore, they fail in the same manner.
127+
# * https://github.com/ethereum/py-evm/pull/1579#issuecomment-446591118
128+
# Interestingly, d2 passes in Constantinople after a refactor of storage handling,
129+
# the same test was already passing in ConstantinopleFix. Since the situation is synthetic,
130+
# not much research went into why, yet.
131+
('GeneralStateTests/stSStoreTest/InitCollision_d0g0v0.json', 'InitCollision_d0g0v0_Constantinople'), # noqa: E501
132+
('GeneralStateTests/stSStoreTest/InitCollision_d1g0v0.json', 'InitCollision_d1g0v0_Constantinople'), # noqa: E501
133+
('GeneralStateTests/stSStoreTest/InitCollision_d2g0v0.json', 'InitCollision_d2g0v0_Constantinople'), # noqa: E501
134+
('GeneralStateTests/stSStoreTest/InitCollision_d3g0v0.json', 'InitCollision_d3g0v0_Constantinople'), # noqa: E501
118135
}
119136

120137
RPC_STATE_NORMALIZERS = {

0 commit comments

Comments
 (0)