Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we support a uint256 chain ID #3824

Open
acolytec3 opened this issue Dec 21, 2024 · 3 comments
Open

Ensure we support a uint256 chain ID #3824

acolytec3 opened this issue Dec 21, 2024 · 3 comments

Comments

@acolytec3
Copy link
Contributor

We should make sure we don't disallow chain IDs up to a uint256 size (i.e. a really big number) per this update to Pectra Devnet 5 specs

Probably what should happen here is we just add a check in common when setting up genesis parameters to make sure the chain ID isn't greater than 2^32 (or whatever the max uint256 is)

@jochem-brouwer
Copy link
Member

jochem-brouwer commented Dec 22, 2024

It looks like this is only intended for the auth lists on 7702. I have implemented that here: 5079664

@acolytec3
Copy link
Contributor Author

Shouldn't we also do this check in common on start up?

@jochem-brouwer
Copy link
Member

We could do a monorepo-wide policy of chain-ids fitting in uint256 to be compatible with other clients? This would not be a candidate for the devnet-5 PR though, should have a follow-up PR on this if we want to do that.

Note: we do not have restrictions by default on the chain id size, so by default we would support "all" chain ids, except that we have some checks in for instance the tx package that this is not higher than some value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants