Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratelimit issues #2

Open
atomfrede opened this issue May 11, 2020 · 5 comments
Open

Ratelimit issues #2

atomfrede opened this issue May 11, 2020 · 5 comments

Comments

@atomfrede
Copy link

Hi @ethomson

Thanks for the nice workflow. I have setup a small dashboard for the jhipster org on github. But we are running now in rate limiting issues (the schedule was at first every hour). Maybe it is related to the configuration as I would like to display more projects than currently on the generated dashboard and thats why running into rate limit.

Is there a way to pass an api user or so, such that the the workflow runs on the higher limit?

If it helps the configuration is here: https://github.com/hipster-labs/github-dashboard

Thanks for help or any hint in advance!

@ethomson
Copy link
Owner

Neat!

Sorry to hear about the rate limit issues. Right now your configuration is running with the github token that's generated for your workflow run. My recollection is that this has the same API limits as a normal user - but I could be wrong. You could try generating a PAT and using that as your token instead (https://github.com/hipster-labs/github-dashboard/blob/master/.github/workflows/dashboard.yml#L272).

But ultimately I think that this action just needs to be smarter about the way it collects data. GitHub hands us back the rate limiting information (how many additional calls you can make, when your limit refreshes), we could take advantage of that to pause data collection until there's a refresh instead of failing miserably like we do now.

@atomfrede
Copy link
Author

Thanks for the quick reply. Will try a personal access token.

@ethomson
Copy link
Owner

Yeah - reading this page suggests that you'll only get 1000 API requests with the github token and you should get 5x more with a PAT. Let me know if that's not enough and we should be able to think about how to pause to keep the rate limit in check.

@atomfrede
Copy link
Author

atomfrede commented May 12, 2020

🤔 It seems not to work (which is strange when looking at the limits). My personal access token has public_repo scope. I scheduled the job for noon maybe something is wrong. I will try to reduce the number of repos for now to see what will happen

@atomfrede
Copy link
Author

Still the same. Rate limit exceeded for my user, even with two projects less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants