Summary: Fixes Style/GlobalStdStream in OSS CI

Reviewed By: joshuamiller01

Differential Revision: D45399133

fbshipit-source-id: 5f5f489bc38ec894cfc96e10c15f29e3d451f05e

… disruptive chef code

Summary:

A method to define when a host can run disruptive chef code.  By default this should be allowed
during provisioning and boot (when the host is presumably drained and unable to be running
a workload)

Reviewed By: gogsbread

Differential Revision: D34600530

fbshipit-source-id: d741d256e47df94bd9360dca7bc628b3a45f6d3b

Summary:

Refactor autostart handling for old systemd versions.  This makes the code
easier to read in differentiating when we're setting up timers the normal way
(with modern systemd) versus the old way, and will make future transitioning to
a different model (forthcoming) simpler also.

This should be a no-op; node['packages'] is ohai-time and reordering the evaluation
within a custom resource should be irrelevant.

Reviewed By: dafyddcrosby

Differential Revision: D45199845

fbshipit-source-id: 12b6ab20c90c59d1c9660f411de9fb29f2b295c4

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff expand actions on CentOS to all other RHEL_Family platforms.

This diff needs stamp from [[chefit](https://www.internalfb.com/permission/group/965392640256092), [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)]

Reviewed By: joshuamiller01

Differential Revision: D45261981

fbshipit-source-id: 5eded266a277b639ca0723394d937f222908a983

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff just used latest rhel_family? functions and added more supported platforms.  No effects on existing systems.

This diff needs stamp from [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)

Differential Revision: D45111725

fbshipit-source-id: 6bf7af74b90a741ac71ea19b1bc169f60f4739d0

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff simply add more supported platforms in the metadata

This diff needs stamp from [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)

Differential Revision: D45262482

fbshipit-source-id: a1e10897b739c29e96123fcdccf8b038111a3bf3

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff expand actions on CentOS to all other RHEL_Family platforms.

This diff simply add more supported platforms in the metadate

This diff needs stamp from [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)

Differential Revision: D45263447

fbshipit-source-id: 200368833ea06464132953e0fb43966a3c0475fe

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff simply add more supported platforms in the metadate

This diff needs stamp from [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)

Differential Revision: D45263741

fbshipit-source-id: 044c581e251964c725d8fe4741a346ac1d515c3d

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff expand actions on CentOS to all other RHEL_Family platforms.

This diff needs stamp from [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)

Differential Revision: D45263995

fbshipit-source-id: 2c87394d302f94906232e9e897dd65b8ffca3181

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff simply add more supported platforms in the metadate

This diff needs stamp from [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)

Differential Revision: D45264038

fbshipit-source-id: 2bd9d1d0cc81ee9cef8a8b0eba9a36c3a04dd8ec

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff simply add more supported platforms in the metadate

This diff needs stamp from [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)

Differential Revision: D45264076

fbshipit-source-id: 13415cd3211344b0cadc2538478a2457f8c3c38a

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff simply add more supported platforms in the metadate

This diff needs stamp from [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)

Differential Revision: D45264112

fbshipit-source-id: 112387fbff20bbfedb7a49b926d308a80ef7c4d6

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff simply add more supported platforms in the metadate

This diff needs stamp from [[chefit](https://www.internalfb.com/permission/group/965392640256092), [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)]

Differential Revision: D45264277

fbshipit-source-id: 3bfd6e6ec59c03b9c9149e24d4d3c3f4cbaf9e93

Summary:

As titled. By checking the [chef infra](https://fburl.com/0rmv1bnc) and [Meta implementation](https://fburl.com/code/tzjadwep), we know:
- *platform*, **centos** and **redhat** are two platforms names
- *platform_family*, **rhel** is a family name that contains centos, redhat, rocky and more.

More context can be found in this [post](https://fburl.com/workplace/1qm17oop).

It looks we have Centos only in prod ([1](https://fburl.com/scuba/chef/k4nsvzfe) and [2](https://fburl.com/scuba/chef/t6xy763c)),  and CentOS, Redhat and OEL platforms in [IT/Corp](https://fburl.com/scuba/ifs_chef/l0wj716g).  And we have no host running with version<7.

This diff simply add more supported platforms in the metadate

This diff needs stamp from [hm_data_plane](https://www.internalfb.com/permission/group/437546304210697)

Differential Revision: D45264375

fbshipit-source-id: 570242a54d1237259ce2babb6940b2b7e1170561

Summary:
* Moved existing logic to extract disk model, firmware and disks in mdarray as `FB::Storage` methods
* No logic change to hosts with rootfs mounted on single disk.
* On hosts where root is mounted on mdarray, we will now encode the sorted models, relative firmwares to aggregation labels.
```
# Separated by __ which is acceptable in ODS
<CUSTOM_ROOT_DISK_MODEL>:__RAID__MZ1LB1T9HBLS-000FB__MZ1LB1T9HBLS-000FB__;
<CUSTOM_ROOT_DISK_FIRMWARE>:__RAID__EDW76F2Q__EDW76F2Q__;
```

Reviewed By: joshuamiller01

Differential Revision: D45419604

fbshipit-source-id: 25c37ad73ae55c2af609c0bf662400788baf179d

…ive chef resources

Summary:

Manage timers directly through systemd rather than via native chef resources.  This is much more
CPU and time performant; managing 50 timer units with the native service chef resource requires
50 expensive shellouts via systemctl (even when no change needs to be made), which we can collapse into a single
shellout to gather the state of all 50 units, and then a single call to enable, and start.

Reviewed By: dafyddcrosby

Differential Revision: D45170124

fbshipit-source-id: 43dc16c23d882dec660816290d12f9b451cbdfbe

…de.rm

Summary:

If during a loop you modify an element of the node object, and then read from the same ImmutibleHash,
it causes some kind of overhead which costs non-trivial amounts of CPU when iterating enough times.

In other words: if you modify node.default['something'][...], then read from node['something'], and then
loop and do that again and again, you get significant perf overhead.

If the read is removed, this overhead is avoided; this diff takes an unnecessary read of `node['fb_timers']['_timer_path']`
and captures it in an lvar, which saves ~5ms per iteration in my environment.

While we're here, also switch from node.rm to node.rm_default, because that's also much less CPU expensive.

Reviewed By: dafyddcrosby

Differential Revision: D45459381

fbshipit-source-id: c641c67a3a6868a6bccb63d4b507a1d510295dad

Summary:

Currently we do not enforce the fluentbit service is set to run at startup and kept running.

One can manually disable/stop the service and it will not self-reenable.

Lets add an attribute to control enforcement of the service state.

Reviewed By: joshuamiller01

Differential Revision: D44970184

fbshipit-source-id: 482ae4678de51a317db3eec3c6f3e0b835be317b

Summary:

Fix require_relative path in libraries_spec to work in GH

Differential Revision: D45500711

fbshipit-source-id: 46df08e140fb11ce08e122546df0110f5e9c4146

…ive chef resources 1% -> 2%

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Reviewed By: dafyddcrosby

Differential Revision: D45501926

fbshipit-source-id: bd522655399aa057425e55824055ebeca0ced08a

…ive chef resources 2% -> 5%

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Reviewed By: dafyddcrosby

Differential Revision: D45501921

fbshipit-source-id: 981413141baca9bfea9d21731fec5b1da96d2b59

…ive chef resources 5% -> 15%

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Reviewed By: dafyddcrosby

Differential Revision: D45501924

fbshipit-source-id: 99a79da6c88922783fa855592fc187600fb79dfc

…ive chef resources 15% -> 25%

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Reviewed By: dafyddcrosby

Differential Revision: D45501922

fbshipit-source-id: 39e06bee2ece139b4bec6ab2e452d5fcae41c44b

…ive chef resources 25% -> 40%

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Reviewed By: dafyddcrosby

Differential Revision: D45501923

fbshipit-source-id: 51fe2cb4e7a62bc150e39ccdfc4f4e0768148326

…ive chef resources 40% -> 60%

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Reviewed By: dafyddcrosby

Differential Revision: D45501918

fbshipit-source-id: db700be5de63820f917a589fa53fbd0f85bcdc3d

…ive chef resources 60% -> 80%

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Reviewed By: dafyddcrosby

Differential Revision: D45501920

fbshipit-source-id: 97895230dffabc6788c657af49d2c0f1ddaf35c0

Summary:

Newer rsyslog has a bug in container builds where it exits immediately.

While we figure out why (which is more complicated than one would expect), reflect changes in D45715090 into Chef solo runs so that booted container runs (i.e. Chef Solo runs) based on images built with booted container runs (i.e. Tupperware Base Image derivatives, in our case the Sandcastle Worker image) once again work.

Reviewed By: wilkotom

Differential Revision: D45725790

fbshipit-source-id: a943ef64d8bea056ab2243fa7ac0d9d925450d89

…ive chef resources 80% -> 100%

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Reviewed By: dafyddcrosby

Differential Revision: D45501919

fbshipit-source-id: 24f55f4cf5e24faf24107fc1d7289132768dcf69

Summary:

Reviewed By: AadityaNair

Differential Revision: D45713557

fbshipit-source-id: a4573894ca8b4b6835c39b27f680e9c20ad0bf4b

Summary:

Reviewed By: DanielGrzegorzewski

Differential Revision: D45709812

fbshipit-source-id: 981a95f5c31130442ce9fda5b66137fac3226f74

Summary: This generally simplifies the existing logic

Reviewed By: dafyddcrosby

Differential Revision: D44694707

fbshipit-source-id: 801370be2a7a4be9ef26827bbd853c1ec14af4de

Summary:

* S341260 revealed that vendor coreboot images have crude assumptions (first 5 lines) to [parse our grub.cfg](https://www.internalfb.com/phabricator/paste/view/P713678956?lines=168-155) and grep for terms like "search"
* Gated retry, search template code under search_enabled attribute
* Added logic to darwin fboss recipe to turn off template code that uses search command to hunt for grubenv

Reviewed By: DanielGrzegorzewski

Differential Revision: D45791452

fbshipit-source-id: 9b5b13b850386b1b47d80e3c3313546e96449a36

Summary:

We recently started pinning a version of rsyslog to work around other bugs, and cargo-culted in an `allow_downgrade` statement.

It seems as though triggering this warning ends up triggering this:
  undefined method `id' for #<Chef::Deprecated::DnfPackageAllowDowngrade:0x0000000007173750>

... and then the world explodes. Let's avoid that.

Reviewed By: AadityaNair

Differential Revision: D45811785

fbshipit-source-id: adeb428984cbf7d07da738e2b78acaf218956ff6

Summary:

In `storage.rb` there is `devices_to_skip` which is filled with all the devices to skip, which are the ones for / and /boot.
If / is mounted from a RAID array, all the devices in the array (e.g. /dev/sda1 and /dev/sdb1) are added to devices_to_skip. But when doing so, partitions are added, not disks.

While at at:
- fix device_name_from_partition() which was unable to handle loop devices and few others
- fix typos in comments
- add more tests

Differential Revision: D45199010

fbshipit-source-id: 7f94df0b70ae416c639928255f6b4b401068adf0

Summary:

Once facebook/between-meals#127 and
facebook/grocery-delivery#66 have been merged, this
version shim can go. We now take an allowlist-based approach with 1.3.1+, so
shouldn't need new shims going forward.

Differential Revision: D45874516

fbshipit-source-id: 15f5d7977dcdb5a426d38cc841a6d54c670b2133

Summary:
This enables the following cops:

- Chef/Deprecations/DeprecatedShelloutMethods
- Chef/Deprecations/WindowsVersionHelpers
- Chef/Modernize/UnnecessaryDependsChef14
- Chef/Modernize/CronDFileOrTemplate
- Chef/Modernize/CronManageResource
- Chef/Modernize/ExecuteScExe
- Chef/Modernize/ExecuteSysctl
- Chef/Modernize/ExecuteTzUtil
- Chef/Modernize/MacOsXUserdefaults
- Chef/Modernize/OpensslRsaKeyResource
- Chef/Modernize/OpensslX509Resource
- Chef/Modernize/PowershellInstallWindowsFeature
- Chef/Modernize/WindowsScResource
- Chef/Modernize/SysctlParamResource

Differential Revision: D45967167

fbshipit-source-id: 9491a32ca63b6256f4cb9c54e805a092e110f00a

Summary:

fix wrong Chef/Meta/NoFileWrites warning

Differential Revision: D45910895

fbshipit-source-id: 4148e8a4e469a7a61aad743b4496d16457ee7c4c

Summary:

Differential Revision: D45922721

fbshipit-source-id: 5da1d74b71e751f91ec8cfaa92c1c2397dadb7b2

Summary:

systemd has automatically mounted /sys/fs/bpf for many years, such that there's no need to mount it
via other means, so update fb_fstab to not automatically unmount it.

Differential Revision: D46297493

fbshipit-source-id: 315a81c2e774ba4e06227d975f3ea4d8d4dc6601

Summary:
This causes a bunch of chef errors, because the chef windows_service resource is not smart enough to wait for `stop pending` to complete
before starting a service, and the fluentbit restart script does a background restart rather than a foreground one, causing this to fall over randomly
on a small percentage of nodes.  Becasuse we know it's coming back in that case, we can just defer doing this until the next run if the service is in that state

Differential Revision: D46238248

fbshipit-source-id: 5b70fbb6250abe509295fe43067903fbeab4d6d0

Summary:

The `.snapshot` directory on the NetApp is a special directory that only gets mounted when its accessed. Since we have `enable_unmount=true`, Chef will attempt to unmount the volume and fail if its in use. Currently we can only ignore by prefix, I decided to add an ignore by regex to give a bit more control vs doing something an include.

Differential Revision: D46297189

fbshipit-source-id: 4e5c614218c271d5c8df9883cb754faf0e5abd91

Summary:

nspawn is split into a subpackage in most distributions, add a knob to
explicitly control whether it's installed

Differential Revision: D46625711

fbshipit-source-id: ecdaa22e2eb671b0876ea58d14482117df1fe86e

Summary: A quick way to visualize cookbook dependency graph

Differential Revision: D46596467

fbshipit-source-id: 051ebeab21d2871fe9bbdff224d08d443edc87d2

…(and use it)

Summary:
Adds a helper function that will configure VLAN for network-scripts and systemd-networkd.

For some reason, the netdev was only added after systemd-networkd restarts (i.e. `networkctl reload` did not work). This case was added to fb_networkd.

Differential Revision: D46560287

fbshipit-source-id: d5089b428f250f0840270cd2fdc22bd8d999ceb8

Differential Revision: D46901582

fbshipit-source-id: 71d44f678e4717976f3fdc11b991ebf137acc70f

Summary:

**Internal:**
With the cleanup of removing `/opt/homebrew`, this helps removes the symlink to the path since it no longer exists.

This gets rid of the need for the symlink of `/opt/homebrew/bin/smartctl` plus gets rid of the 2014 Mac Mini hardware.

There shouldn't have any (CPE-specific) use case for 2014 mac minis, so any code explicitly targeting them is almost certainly a safe candidate for summary removal.

As someone once stated, "*they should be lovingly and affectionately hit with a blackjack and have it confiscated. :)*"

Plus, `fb_macos_shared::smartmontools` recipe already handles the nix version of this tool, making this cookbook redundant.

Differential Revision: D46707384

fbshipit-source-id: c6475554f3c878270fa760a9b4ad8df377d532d3

Summary: Internal linter didn't fire on this in D43891262, breaking OSS CI.

Differential Revision: D47217370

fbshipit-source-id: b506e7d22a34ae6be2468b768c95e554afe04483

Summary:

This has been migrated off foodcritic to rubocop

Differential Revision: D47346023

fbshipit-source-id: 8485a3a3d002311f4dd379ac0b01d2b545c2e9cf

Summary:
Was fixed in D34117172

Differential Revision: D47267603

fbshipit-source-id: 45819a012a83bb8fea802e247265660e25e4c2fd

Summary:

Fixes: facebook#223

Differential Revision: D47370901

fbshipit-source-id: 360fc4f40cec63a7ff3b0b4a36ee131122f3faee

Summary:

Unit tests against anything which uses the gated_template resource are difficult.
This changes the way the resource is handled slightly to ease testing.
With that fix, some of the previous hacks to make this spec possible are no longer necessary,
so clean up the UserID crap

Within the custom resource, this switches from `converge_by` to use a template resource.  This should
be equivalent (if not DRY), but is what makes the unit testing work properly.  I tested the usual flow
for this via taste-tester, to confirm:

- Within permission, the file is not changed, and permission is requested
- With permission, the file is changed, and permission request is cleaned up
- With no change required, nothing happens

Differential Revision: D46749176

fbshipit-source-id: 1f0bd74d2a2929dcf62841b94f9bfa182f660369

…ndering

Summary:

fb_networkd: add unit tests for network, link, and netdev template rendering

Differential Revision: D46488690

fbshipit-source-id: c020557ab4632d82b8aba886b4458bcc68570c0b

Summary:
Bootstrap chef core cookbooks to RHEL 9

Differential Revision: D47532272

fbshipit-source-id: ff6d26338709f65e0eb17df20106761e0a2b68f2

…cebook#224)

Summary:

## Description

`fb_modprobe`
- Updates the cookbook metadata to support `ubuntu`.

`fb_systemd`
- Adds the required `systemd-timesyncd` package when `timesyncd` is enabled.
- Adds the `dns` resolver to the `fb_nsswitch` configuration to be used as a fallback to `systemd-resolved`. This is a recommended configuration for `nss-resolve`: https://man7.org/linux/man-pages/man8/nss-resolve.8.html.

## Impact

These cookbooks will now be able to converge on Ubuntu Jammy.

Pull Request resolved: facebook#224

Differential Revision: D47484960

fbshipit-source-id: 2eefa662eeec5762f9927c69c4f344693d871c9b

Summary: Ruby 2.4 is EOL, and the tests will fail when we bump RuboCop versions

Differential Revision: D47607760

fbshipit-source-id: ff0929a52599214bad944ef772b556e8467670ef

Summary: Ruby 3.1 is what's running in the latest Chef Infra client versions.

Differential Revision: D47609973

fbshipit-source-id: 526242491c6bc7495d4ded115b087ae39eef988f

Summary:
These versions work on Ruby 2.5. The warnings from the newly disabled
`Chef/Sharing` lints are new, so we'll ratchet those back in along with the two new
`rubocop:todo` lines. `Chef/Style/CommentSentenceSpacing` is broken in 7.32.1,
fixed in 7.32.3

Differential Revision: D47609492

fbshipit-source-id: 06f3ef56c7e177254d71d660656b0a7397563ad7

Summary:
Activates the following lints which, while enabled in cookstyle.yml, weren't running due to the unmet

- Chef/Modernize/LibarchiveFileResource
- Chef/Deprecations/MacosUserdefaultsGlobalProperty
- Chef/Deprecations/PoiseArchiveUsage
- Chef/Modernize/PowershellScriptExpandArchive
- Chef/Modernize/SevenZipArchiveResource
- Chef/Modernize/WindowsRegistryUAC
- Chef/Modernize/WindowsZipfileUsage
- Chef/Modernize/ZipfileResource

Chef/Deprecations/LogResourceNotifications will need to be ratcheted in.

Differential Revision: D47613067

fbshipit-source-id: c7c7ca4bff79c2862a1dd1e8a4f8859f3ee989f0

Summary:
The open-source RuboCop version pin is now greater than 1.19

Differential Revision: D47802717

fbshipit-source-id: 16bc3e92c95bce46e4d87dd6c5740b57ab2cbf1f

Summary:
Doing proactive cosmetic cleanup before doing work to clean up missing/unused dependencies.

Differential Revision: D47775954

fbshipit-source-id: de9d0d46601ac74ab700b5480b1b3ddccd6c0607

Summary:
This loop triggers a DeepMergeCache flap. Moving the globals outside
the loop fixes the flap, and uses a single node.default write for the block

Differential Revision: D47308032

fbshipit-source-id: 86a13dbc408859021e6466daecfd3fc6af3b9871

Summary:
Too noisy, and doesn't really serve a functional purpose (ie AST
mutation).

Differential Revision: D47836299

fbshipit-source-id: d92de51a22a4949491b1860614c91ff7f0f14d4f

… device

Summary:

We prefer to use labels rather than devices, because device numbers can be reordered
after device changes / kernel changes.  If there is a swap device, and it has a label,
use that.

Differential Revision: D47889869

fbshipit-source-id: 1ac6ad7d8812db96262a61d53e6a061076dd86c0

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Differential Revision: D47948323

fbshipit-source-id: 5c139eb1f4c6eae45a1debe907eb08ca14774519

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Differential Revision: D47948322

fbshipit-source-id: d1c562314da0b908eb5603e2997e7793409f23da

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Differential Revision: D47948321

fbshipit-source-id: 8c6ecf7ce5a95be24058c66ddfb5e2952c31fd0a

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Differential Revision: D47948320

fbshipit-source-id: 9b7de3c71e7fdc184f701b8f4283e9a063dc6489

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Differential Revision: D47948318

fbshipit-source-id: f3c2257cf0ad61fc57e3061730a1a0bda65ad29f

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Differential Revision: D47948319

fbshipit-source-id: d1e947046789f8c75979b9a73207bf474990fda5

Summary:
There are scenarios where we need to take some action after a networkd change
has been made.  This builds this API into fb_networkd, such that the set of resources and actions
to run via notifications can be set via a node API.

Differential Revision: D47993625

fbshipit-source-id: 1f208b18016a9b82ac44078856ae693932fe0650

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Differential Revision: D47948316

fbshipit-source-id: 25a3216302b4cb51c46c1802c4b44a7145c7a522

Summary:
bumpsign

This diff was created using http://fburl.com/chefshardbump

Differential Revision: D47948317

fbshipit-source-id: dd8dc273faf11840321f47e6afd0416e13ad5be4

Summary:
These are either non-AST mutating or otherwise make suggestions that
don't make sense to our envs.

Differential Revision: D48081695

fbshipit-source-id: caab0af6d88bfdbf9f9fc38904223645a64904d6

Summary:
Now that we're requiring a recent Cookstyle release in the OSS repo, there's a bunch of new lints we can turn on.

```
Chef/Correctness/InvalidCookbookName
Chef/Correctness/MetadataMalformedDepends
Chef/Correctness/MetadataMissingVersion
Chef/Correctness/PowershellFileExists
Chef/Deprecations/ChefSugarHelpers
Chef/Deprecations/DependsOnChefNginxCookbook
Chef/Deprecations/DependsOnChefReportingCookbook
Chef/Deprecations/DependsOnOmnibusUpdaterCookbook
Chef/Deprecations/DeprecatedSudoActions
Chef/Deprecations/FoodcriticFile
Chef/Deprecations/HWRPWithoutUnifiedTrue
Chef/Deprecations/PolicyfileCommunitySource
Chef/Modernize/DeclareActionClass
Chef/Modernize/DependsOnChefVaultCookbook
Chef/Modernize/DependsOnChocolateyCookbooks
Chef/Modernize/DependsOnKernelModuleCookbook
Chef/Modernize/DependsOnLocaleCookbook
Chef/Modernize/DependsOnOpensslCookbook
Chef/Modernize/DependsOnTimezoneLwrpCookbook
Chef/Modernize/DependsOnWindowsFirewallCookbook
Chef/Modernize/UnnecessaryDependsChef15
Chef/Modernize/UseChefLanguageEnvHelpers
Chef/Modernize/UseChefLanguageSystemdHelper
Chef/Security/SshPrivateKey
```

Differential Revision: D48082338

fbshipit-source-id: 6903365fdea3b3c303268dec19e032220278cd11

Summary:

Differential Revision: D48331038

fbshipit-source-id: 17ac13d93737a885188e432ec89349b5ad42f2f6

Summary:
Chef 18 defaults `unified_mode` to `true`, setting explicitly to false
so that they can be ratcheted to true as they've been audited. This is the
start of addressing the open-source issue
facebook#178

- https://docs.chef.io/release_notes_client/#18.0.155-unified-mode-in-custom-resources
- https://docs.chef.io/unified_mode/

Differential Revision: D48282167

fbshipit-source-id: cd746aeeae2e2cf58abb806cc587d64d1250091a

Summary: Pull Request resolved: facebook#227

Differential Revision: D48485699

fbshipit-source-id: c457726e503caba0e30c398f0b6682e91f535b13

Summary:
Metadata claims it supports Debian and Ubuntu but this was breaking tests because Debian packages weren't provided

Pull Request resolved: facebook#219

Test Plan: Debian Test Kitchen CI no longer failing on fb_smokeping https://github.com/facebook/chef-cookbooks/actions/runs/5930863707/job/16081523013?pr=219

Differential Revision: D44802567

fbshipit-source-id: 4b8a032b747e63a7e95985114c7e3610cbf4033a

Summary:
The end result of this is working rubocop/chefspec tests (which have been broken for a while now, so I'm happy to be seeing green). Test Kitchen fixes are out of scope for this one, since there's a bunch more work in that area.

Pull Request resolved: facebook#229

Differential Revision: D48526808

fbshipit-source-id: 59dca361538e863adcd8bd7bea23269abb164777

Summary: Pull Request resolved: facebook#228

Differential Revision: D48697284

fbshipit-source-id: 0570795f48b31ef81a7af42f93dbbece01dcfc18

Summary:

The diff adds new default Xcode CLI tools package which is compatible with Sonoma
Also the diff adds a function to check if node is macOS 14

Followed the guide here https://www.internalfb.com/intern/wiki/PE_macOS/Internal/MacOS_upgrade_rollout_Runbook/

Differential Revision: D48828827

fbshipit-source-id: 7c7ff8cb0b8396d4192831fe5b153b189edb4e33

Summary:

antlir2 builds never have a booted systemd as pid1, so any dbus interactions will fail

This diff no-ops:
- `daemon-reload`
- `daemon-reexec`

and branches with `--root=/` for:
- `set-default`

Differential Revision: D48618221

fbshipit-source-id: 4cecc50040bcbae7325063bdca7e1c9fffd07868

Summary:
This breaks opensource customers.

Fixes: facebook#230

Original commit changeset: 4cecc50040bc

Original Phabricator Diff: D48618221

Differential Revision: D48906694

fbshipit-source-id: ec2e443ccb22a044507c467254b8a4c48cdabf38

Summary:

The current `.existing_partitions` uses a simple `starts_with` but there is a corner case: when /dev/sda is queried, the partitions returned include partitions under /dev/sdaa.

This bug affects drive hotswap because when /dev/sda is replaced, Chef Storage API tries to mark all /dev/sda* partitions as failed. That includes /dev/sdaa* partitions, which are in use - and Chef fails. Example: https://www.internalfb.com/intern/provisioning/asset_details/3533538530193558

Fix is to change implementation to regex that checks for numbers after device name.

Differential Revision: D49239939

fbshipit-source-id: 55b6a664ed135114c6f0246692126afe06efafe7

Summary:
When checking a field, we downcase the subcommand.

Pull Request resolved: facebook#231

Differential Revision: D49431911

fbshipit-source-id: 5d9b3883e0fc5ac1b05741fce1348b66ade37964

Summary:
There's a speed benefit to combining the runs, both in only crawling
the files once, and reducing linter whack-a-mole.

Differential Revision: D45196190

fbshipit-source-id: 99fc2e3c71b5a190a651ce7738b475142df6a51d

Summary:

antlir2 image builds don't run systemd services which exposed this deficiency.

Generally though, if Chef is being used to manage files in a directory, it
should also ensure that that directory exists, otherwise there can be fun race
conditions :)

Differential Revision: D49016526

fbshipit-source-id: 5a130e2bf37d5a772116605b1f2d8136f783d1b4

Summary:

Sometimes modules can have the same command names. When installing a new module, PowerShell will halt the installation if a command in a new module is found in a previously installed module. `-AllowClobber` bypasses this check.

Differential Revision: D49525952

fbshipit-source-id: f6f7e4e262bba7e553990210c9a4396f6a1de915

Summary:

This adds Windows 11 management support to WuFB that currently only handles Windows 10.  Since we aren't updating Windows 10 devices to Windows 11 we needed to add support for **Product Version** 10 __**and**__ 11 using a node detection.   This way both version of Windows can get their feature/build updates but stay on their major release.

With this, I'm pushing 22H2 to __CPE__ first to validate its function and successful upgrades, and later Trusted Testers.

**Upgrade impact is minimal**; both Windows 10 and 11 Build 21H1 went to 22H2 with a reboot that takes __less than 1 minute__ to apply.

Differential Revision: D49306013

fbshipit-source-id: c80b450581cf86371f21517467ce4fed263e6b62

Summary:

Since the config to `fb_tmpreaper` is now in `/usr/local/bin`, its now safe to remove the part where it used to be in `/usr/bin`.

Differential Revision: D49381715

fbshipit-source-id: 2e4155974de4aba76dec516f6979a1a1fcd857db

Summary:

1. Several methods cast strings into version and it's very likely this is happening multiple times unnecessarily.
2. Several Windows assume versions would be unique to server/desktop and it's a bad assumption. The methods have been updated to confirm this.

Differential Revision: D49522597

fbshipit-source-id: 9eab128fbdbb5aefec41462c996b202d3fcf034f

Summary:

Pwsh collects some telemetry on start up. This allows us to turn it off. If attribute is unset, it does nothing. Setting true or false will enable/disable.

https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_telemetry?view=powershell-7.3

Differential Revision: D50018656

fbshipit-source-id: 717106af63fa781e99a0f767356b85011e492128