Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explicitly depend on fb_sysfs in fb_storage #26

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

russtaylor
Copy link

Description

Explicitly includes fb_sysfs as part of the fb_storage cookbook.

Context

When I tried spinning up a different VM type that uses NVMe-based storage, I noticed that chef was failing. After further debugging, I realized that in certain cases (such as for NVMe devices), fb_storage calls out to fb_sysfs. However, fb_storage never explicitly includes fb_sysfs, so by default it's not available and causes the chef run to fail.

Testing Plan

I ran manual tests via Packer - to do this, I had to manually change the instance size to one that supports hyperdisks (I used c3-standard-22) and then manually attached a hyperdisk to the instance. When I added the explicit depends fb_sysfs, that solved the issue and fb_storage was able to format and mount the drive as expected.

Other Considerations

I'm not sure what other implications this might have; Maybe there's a reason fb_sysfs wasn't included explicitly and this will cause failures with non-NVMe devices?

Copy link

@ericnorris ericnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as @adsr on Slack - I'm guessing upstream would take this as a PR as well, could we try submitting it there too?

@russtaylor russtaylor merged commit b774201 into main Jul 29, 2024
1 of 10 checks passed
@russtaylor russtaylor deleted the russt.DP-5535.explicitly-include-fb-sysfs branch July 29, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants