fix: Explicitly depend on fb_sysfs in fb_storage #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly includes
fb_sysfs
as part of thefb_storage
cookbook.Context
When I tried spinning up a different VM type that uses NVMe-based storage, I noticed that chef was failing. After further debugging, I realized that in certain cases (such as for NVMe devices),
fb_storage
calls out tofb_sysfs
. However,fb_storage
never explicitly includesfb_sysfs
, so by default it's not available and causes the chef run to fail.Testing Plan
I ran manual tests via Packer - to do this, I had to manually change the instance size to one that supports hyperdisks (I used
c3-standard-22
) and then manually attached a hyperdisk to the instance. When I added the explicitdepends fb_sysfs
, that solved the issue andfb_storage
was able to format and mount the drive as expected.Other Considerations
I'm not sure what other implications this might have; Maybe there's a reason
fb_sysfs
wasn't included explicitly and this will cause failures with non-NVMe devices?