fix to modifiable order selection

Author: ettec

react/opentp-client/src/common/grpcUtilities.tsx

@@ -57,7 +57,7 @@ export function getGrpcErrorMessage( error : Error, prepend?: string) : string {
             grpErrorCodeAsStr = "Unimplemented"
             break 
         case StatusCode.UNKNOWN: 
-        grpErrorCodeAsStr = "Unknown Host"
+        grpErrorCodeAsStr = "Unknown"
             break
 
     }    

react/opentp-client/src/components/Login/Login.tsx

@@ -54,7 +54,7 @@ export default class Login extends React.Component<Props, State> {
         }
 
         if (this.serverUrl.endsWith("localhost:3000")) {
-            this.serverUrl = "http://127.0.0.1:30262" // for local dev, change this to point at your otp services cluster
+            this.serverUrl = "http://127.0.0.1:31441" // for local dev, change this to point at your otp services cluster
         }
 
         log.info("Connecting to services at:" + this.serverUrl)

react/opentp-client/src/components/OrderBlotter/ParentOrderBlotter.tsx

@@ -182,7 +182,7 @@ const columnDefs: ColDef[] = [
 
 
 interface ParentOrderBlotterState {
-  selectedOrders: Array<Order>
+  selectedOrderViews: Array<OrderView>
 }
 
 interface ParentOrderBlotterProps {
@@ -256,7 +256,7 @@ export default class ParentOrderBlotter extends React.Component<ParentOrderBlott
 
 
     let blotterState: ParentOrderBlotterState = {
-      selectedOrders: new Array<Order>(),
+      selectedOrderViews: new Array<OrderView>(),
     }
 
     this.state = blotterState;
@@ -411,57 +411,70 @@ export default class ParentOrderBlotter extends React.Component<ParentOrderBlott
 
   onSelectionChanged() {
 
-    let selectedOrders = new Array<Order>()
+    let selectedOrders = new Array<OrderView>()
     if (this.gridApi) {
       var selectedRows = this.gridApi.getSelectedRows();
 
       selectedRows.forEach(function (selectedRow, index) {
 
         let orderView: OrderView = selectedRow
 
-        selectedOrders.push(orderView.getOrder())
+        selectedOrders.push(orderView)
 
       });
 
     }
 
     let newState: ParentOrderBlotterState = {
       ...this.state, ...{
-        selectedOrders: selectedOrders,
+        selectedOrderViews: selectedOrders,
       }
     }
 
     this.setState(newState)
 
   };
 
-  getCancellableOrders(orders: Array<Order>): Array<Order> {
+  getCancellableOrders(orders: Array<OrderView>): Array<Order> {
 
     let result = new Array<Order>()
     for (let order of orders) {
-      if (order.getStatus() === OrderStatus.LIVE) {
-        result.push(order)
+      if (order.getOrder().getStatus() === OrderStatus.LIVE) {
+        result.push(order.getOrder())
       }
     }
 
     return result
   }
 
+  getModifiableOrder(views: Array<OrderView>): Order | undefined {
+
+    if( views.length === 1 ) {
+        let view = views[0]
+        if( view.getOrder().getDestination() === view?.getListing()?.getMarket()?.getMic() &&
+        view.getOrder().getDestination() !== Destinations.SMARTROUTER ) {
+          return view.getOrder()
+        }
+    }
+
+   return undefined
+  }
+
 
 
   public render() {
 
-    let selectedOrders = this.state.selectedOrders
-    let cancelleableOrders = this.getCancellableOrders(this.state.selectedOrders)
+    let selectedOrders = this.state.selectedOrderViews.map(v=>v.getOrder())
+    let cancelleableOrders = this.getCancellableOrders(this.state.selectedOrderViews)
+    let modifiableOrder = this.getModifiableOrder(this.state.selectedOrderViews)
 
 
     return (
       <div style={{ width: "100%", height: "100%", display: 'flex', flexDirection: 'column', alignItems: "centre" }}>
         <div className="bp3-dark" style={{ display: 'flex', flexDirection: 'row', paddingTop: 0, alignItems: "left" }}>
           <div style={{ flexGrow: 1 }}>
             <Button minimal={true} icon="delete" text="Cancel Orders" onClick={() => this.cancelOrder(cancelleableOrders)} disabled={cancelleableOrders.length === 0} />
-            <Button minimal={true} icon="edit" text="Modify Order" onClick={() => this.modifyOrder(cancelleableOrders[0])} disabled={cancelleableOrders.length !== 1 ||
-              cancelleableOrders[0].getOwnerid() === Destinations.VWAP || cancelleableOrders[0].getOwnerid() === Destinations.SMARTROUTER} />
+            <Button minimal={true} icon="edit" text="Modify Order" onClick={() => this.modifyOrder(cancelleableOrders[0])} disabled={!modifiableOrder} />
             <Button minimal={true} icon="fork" text="Child Orders" onClick={() => this.showChildOrders(selectedOrders.values())} disabled={selectedOrders.length !== 1} />
             <Button minimal={true} icon="bring-data" text="Order History" onClick={() => this.showOrderHistory(selectedOrders.values())} disabled={selectedOrders.length !== 1} />
             <Button minimal={true} icon="tick" text="Executions" onClick={() => this.showExecutions(selectedOrders.values())} disabled={selectedOrders.length !== 1} />

react/opentp-client/src/components/OrderTicket/OrderTicket.tsx

@@ -393,7 +393,7 @@ export default class OrderTicket extends React.Component<OrderTicketProps, Order
 
     let destinations = new Array<string>()
     let destination = Destinations.DMA
-    if (order.getOwnerid() !== newListing.getMarket()?.getMic()) {
+    if (order.getDestination() !== newListing.getMarket()?.getMic()) {
       destination = order.getOwnerid()
       destinations.push(order.getOwnerid())
     } else {