Skip to content

Commit 2f64656

Browse files
committed
prevent entering player options when starting replays
this does not break anything but also is an odd break in the order of execution if you think about it
1 parent 0245024 commit 2f64656

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

src/Etterna/Screen/Others/ScreenSelectMusic.cpp

+9-2
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,7 @@ ScreenSelectMusic::Input(const InputEventPlus& input)
433433
// reset announcer timer
434434
m_timerIdleComment.GetDeltaTime();
435435

436-
// debugging?
437-
// I just like being able to see untransliterated titles occasionally.
436+
// toggle transliteration
438437
if (input.DeviceI.device == DEVICE_KEYBOARD &&
439438
input.DeviceI.button == KEY_F9) {
440439
if (input.type != IET_FIRST_PRESS)
@@ -445,6 +444,14 @@ ScreenSelectMusic::Input(const InputEventPlus& input)
445444
return true;
446445
}
447446

447+
// dont allow touching anything on the transition into view eval/replays
448+
// the only time this would not be null is if replay is being started
449+
// it is nulled at the start of this screen
450+
// if input breaks, this is why (it shouldnt break)
451+
if (PlayerAI::pScoreData != nullptr) {
452+
return false;
453+
}
454+
448455
if (!IsTransitioning() && m_SelectionState != SelectionState_Finalized) {
449456
auto bHoldingCtrl =
450457
INPUTFILTER->IsBeingPressed(

0 commit comments

Comments
 (0)