remove tn.pn references from notedatautil

Author: MinaciousGrace

src/Etterna/Models/NoteData/NoteDataUtil.cpp

@@ -66,7 +66,6 @@ LoadFromSMNoteDataStringWithPlayer(NoteData& out,
 								   const RString& sSMNoteData,
 								   int start,
 								   int len,
-								   PlayerNumber pn,
 								   int iNumTracks)
 {
 	/* Don't allocate memory for the entire string, nor per measure. Instead,
@@ -232,7 +231,6 @@ LoadFromSMNoteDataStringWithPlayer(NoteData& out,
 				 * to remove anything in this position.  We know that there's
 				 * nothing there, so avoid the search. */
 				if (tn.type != TapNoteType_Empty && ch != '3') {
-					tn.pn = pn;
 					out.SetTapNote(iTrack, iIndex, tn);
 				}
 
@@ -549,7 +547,7 @@ NoteDataUtil::LoadFromSMNoteDataString(NoteData& out,
 	out.Init();
 	out.SetNumTracks(iNumTracks);
 	LoadFromSMNoteDataStringWithPlayer(
-	  out, sSMNoteData, 0, sSMNoteData.size(), PLAYER_INVALID, iNumTracks);
+	  out, sSMNoteData, 0, sSMNoteData.size(), iNumTracks);
 }
 
 void
@@ -875,7 +873,6 @@ NoteDataUtil::LoadTransformedSlidingWindow(const NoteData& in,
 			int iOldTrack = t;
 			int iNewTrack = (iOldTrack + iCurTrackOffset) % iNewNumTracks;
 			TapNote tn = in.GetTapNote(iOldTrack, r);
-			tn.pn = PLAYER_INVALID;
 			out.SetTapNote(iNewTrack, r, tn);
 		}
 	}
@@ -945,7 +942,6 @@ NoteDataUtil::LoadOverlapped(const NoteData& in,
 			if (tnFrom.type == TapNoteType_Empty ||
 				tnFrom.type == TapNoteType_AutoKeysound)
 				continue;
-			tnFrom.pn = PLAYER_INVALID;
 
 			// If this is a hold note, find the end.
 			int iEndIndex = row;
@@ -1323,22 +1319,6 @@ NoteDataUtil::RemoveAllButOneTap(NoteData& inout, int row)
 	inout.RevalidateATIs(vector<int>(), false);
 }
 
-void
-NoteDataUtil::RemoveAllButPlayer(NoteData& inout, PlayerNumber pn)
-{
-	for (int track = 0; track < inout.GetNumTracks(); ++track) {
-		NoteData::iterator i = inout.begin(track);
-
-		while (i != inout.end(track)) {
-			if (i->second.pn != pn && i->second.pn != PLAYER_INVALID)
-				inout.RemoveTapNote(track, i++);
-			else
-				++i;
-		}
-	}
-	inout.RevalidateATIs(vector<int>(), false);
-}
-
 // TODO: Perform appropriate matrix calculations for everything instead.
 static void
 GetTrackMapping(StepsType st,

src/Etterna/Models/NoteData/NoteDataUtil.h

@@ -139,8 +139,7 @@ RemoveStretch(NoteData& inout,
 			  int iEndIndex = MAX_NOTE_ROW);
 void
 RemoveAllButOneTap(NoteData& inout, int row);
-void
-RemoveAllButPlayer(NoteData& inout, PlayerNumber pn);
+
 /** @brief The types of transformations available for the NoteData. */
 enum TrackMapping
 {