Skip to content

Commit b7a2e35

Browse files
author
Csókás, Bence
committed
udev-rules: Fix compile errors with -DDEBUG=1
`DEBUG` turns on some - apparently untested - code that causes compile errors (see linked GitHub issue). Fixing up the unfinished migration to `strbuf`s solves this problem. Fixes: 915bf0f ("udev: use strbuf to store rules strings") Closes: #287 Signed-off-by: Csókás, Bence <[email protected]>
1 parent fc9050c commit b7a2e35

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/udev/udev-rules.c

+7-7
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,8 @@ static void dump_token(struct udev_rules *rules, struct token *token) {
326326
enum token_type type = token->type;
327327
enum operation_type op = token->key.op;
328328
enum string_glob_type glob = token->key.glob;
329-
const char *value = str(rules, token->key.value_off);
330-
const char *attr = &rules->buf[token->key.attr_off];
329+
const char *value = rules_str(rules, token->key.value_off);
330+
const char *attr = rules_str(rules, token->key.attr_off);
331331

332332
switch (type) {
333333
case TK_RULE:
@@ -337,9 +337,9 @@ static void dump_token(struct udev_rules *rules, struct token *token) {
337337
unsigned int idx = (tk_ptr - tks_ptr) / sizeof(struct token);
338338

339339
log_debug("* RULE %s:%u, token: %u, count: %u, label: '%s'",
340-
&rules->buf[token->rule.filename_off], token->rule.filename_line,
340+
rules_str(rules, token->rule.filename_off), token->rule.filename_line,
341341
idx, token->rule.token_count,
342-
&rules->buf[token->rule.label_off]);
342+
rules_str(rules, token->rule.label_off));
343343
break;
344344
}
345345
case TK_M_ACTION:
@@ -436,11 +436,11 @@ static void dump_token(struct udev_rules *rules, struct token *token) {
436436
static void dump_rules(struct udev_rules *rules) {
437437
unsigned int i;
438438

439-
log_debug("dumping %u (%zu bytes) tokens, %u (%zu bytes) strings",
439+
log_debug("dumping %u tokens (%zu bytes), %zu strings (%zu bytes)",
440440
rules->token_cur,
441441
rules->token_cur * sizeof(struct token),
442-
rules->buf_count,
443-
rules->buf_cur);
442+
rules->strbuf->in_count,
443+
rules->strbuf->in_len);
444444
for (i = 0; i < rules->token_cur; i++)
445445
dump_token(rules, &rules->tokens[i]);
446446
}

0 commit comments

Comments
 (0)