-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier install #30
Comments
I agree, README needs these updates |
The 81:81 change is only necessary if you have something running on port 80. If you're using boot2docker, then you have a separate network interface where nothing should be conflicting. But it depends on how you use it. |
Perhaps a mention if using boot2docker that the proper URL for your host machine would be the |
totty90 is right, specifically about the last suggestion. |
Thanks. I've updated the README to use the fully qualified name. Any PRs for clarification of usage are welcome. |
A suggestion for the README: The current instructions say:
Consider adding something that explains which of these is the internal port and which is the outside port. People already running a Website off their own server probably will not have outside port 80 available and will need to use something else. Perhaps use an example where the two port numbers are different, or point out that the first port number is the outside port. The current phrasing ("The -p 80:80 maps the internal docker port 80 to the outside port 80 of the host machine") implies that the the first port is the internal port. |
Hi @Neurogami. Happy to take any README improvements. Would you be able to have a crack at an improvement and do a PR? |
Instead of
Use
Also the
should be changed to:
The text was updated successfully, but these errors were encountered: