Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier install #30

Open
totty90 opened this issue Oct 27, 2014 · 7 comments
Open

Easier install #30

totty90 opened this issue Oct 27, 2014 · 7 comments

Comments

@totty90
Copy link

totty90 commented Oct 27, 2014

Instead of

$ git clone https://github.com/eugeneware/docker-wordpress-nginx.git
$ cd docker-wordpress-nginx
$ sudo docker build -t="docker-wordpress-nginx" .

Use

docker pull eugeneware/docker-wordpress-nginx.

Also the

$ sudo docker run -p 80:80 --name docker-wordpress-nginx -d docker-wordpress-nginx

should be changed to:

sudo docker run -p 81:80 -d eugeneware/docker-wordpress-nginx
@valentt
Copy link

valentt commented Jan 7, 2015

I agree, README needs these updates

@eugeneware
Copy link
Owner

The 81:81 change is only necessary if you have something running on port 80.

If you're using boot2docker, then you have a separate network interface where nothing should be conflicting. But it depends on how you use it.

@denisinla
Copy link

Perhaps a mention if using boot2docker that the proper URL for your host machine would be the
ENV IP that boot2docker tells you to export upon initial install.

@gwhite-dayspring
Copy link

totty90 is right, specifically about the last suggestion.
'eugeneware/' needs to be added before the image name at the end of the docker run command. docker-wordpress-nginx by itself wasn't able to find the image I had just pulled. Adding that specificity of eugeneware/ makes it so that docker doesn't try to find it elsewhere.

@eugeneware
Copy link
Owner

Thanks. I've updated the README to use the fully qualified name. Any PRs for clarification of usage are welcome.

@Neurogami
Copy link

A suggestion for the README: The current instructions say:

To spawn a new instance of wordpress on port 80.  The -p 80:80 maps the internal docker port 80 to the outside port 80 of the host machine.

Consider adding something that explains which of these is the internal port and which is the outside port.

People already running a Website off their own server probably will not have outside port 80 available and will need to use something else.

Perhaps use an example where the two port numbers are different, or point out that the first port number is the outside port.

The current phrasing ("The -p 80:80 maps the internal docker port 80 to the outside port 80 of the host machine") implies that the the first port is the internal port.

@eugeneware
Copy link
Owner

Hi @Neurogami. Happy to take any README improvements. Would you be able to have a crack at an improvement and do a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants