Remove UDP support

Author: IridiumXOR

README.md

@@ -73,7 +73,6 @@ Other distributions provide equivalent packages, which at minimum allow compilin
 - [ ] Support other CPU architectures (x32, ARM32, MIPS, PowerPC, POWER, RISC-V)
 - [ ] Use of `_stext` in x64 to bypass missing `CONFIG_KALLSYMS_ALL`
 - [ ] Bruteforce scanning (?) for page containing same data of  `_stext` page in ARM64 to bypass missing `CONFIG_KALLSYMS_ALL`
-- [ ] Implement network dump (UDP)
 
 ## Notes
 

lemon.c

@@ -24,7 +24,6 @@ static const struct argp_option options[] = {
     {"disk",      'd', "PATH",      0, "Dump on disk", 0},
     {"network",   'n', "ADDRESS",   0, "Dump through the network", 1},
     {"port",      'p', "PORT",      0, "Specify port number", 1},
-    {"udp",       'u', 0,           0, "Use UDP instead of TCP", 1},
     {"realtime",  'r', 0,           0, "Use realtime priority", 2},
     {"fatal",     'f', 0,           0, "Interrupt the dump in case of memory read error", 2},
     {"raw",       'w', 0,           0, "Produce a RAW dump instead of a LiME one", 2},
@@ -71,10 +70,6 @@ static error_t parse_opt(int key, char *arg, struct argp_state *state) {
         case 'f':
             opts->fatal = true;
             break;
-        case 'u':
-            opts->udp = true;
-            fprintf(stderr, "To be implemented...\n");
-            exit(EXIT_FAILURE);
         case 'w':
             opts->raw = true;
             break;

lemon.h

@@ -9,7 +9,6 @@
 
 #define HUGE_PAGE_SIZE          2 * 1024 * 1024         /* Same for huge pages */
 #define DEFAULT_PORT            2304                    /* Default port used for networt dump */
-#define UDP_MAX_PAYLOAD         1024                    /* Maximum payload for UDP socket */
 
 #define WARN(msg, ...) fprintf(stderr, "WARNING: " msg "\n", ##__VA_ARGS__)
 
@@ -24,7 +23,6 @@ struct options {
     /* Network options */
     unsigned long address;
     unsigned short port;
-    bool udp;
 
     /* Options */
     bool realtime;

net.c

@@ -8,7 +8,6 @@ extern int dump(const struct options *restrict opts, const struct ram_regions *r
 
 /* Arguments passed to write_on_socket() */
 struct net_args {
-    bool udp;
     int sockfd;
 };
 
@@ -54,7 +53,7 @@ int dump_on_net(const struct options *restrict opts, const struct ram_regions *r
     int ret;
 
     /* Create socket */
-    sockfd = socket(AF_INET, opts->udp ? SOCK_DGRAM : SOCK_STREAM, 0);
+    sockfd = socket(AF_INET, SOCK_STREAM, 0);
     if (sockfd < 0) {
         perror("Fail to open network socket");
         return errno;
@@ -73,7 +72,6 @@ int dump_on_net(const struct options *restrict opts, const struct ram_regions *r
 
     /* Setup arguments for write_on_socket */
     net_args.sockfd = sockfd;
-    net_args.udp = opts->udp;
 
     /* Dump! */
     ret = dump(opts, ram_regions, write_on_socket, (void *)&net_args);