Refactor CTDRefDataFetcher to argopy.related #300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean-up dat_fetchers __init__ because all classes have the same name as sub-modules
|
This pull request was marked as staled automatically because it has not seen any activity in 90 days |
|
I'm not sure this PR could go through, the current design makes very difficult to avoid circularity |
|
This pull request was marked as staled automatically because it has not seen any activity in 90 days |
|
This pull request was marked as staled automatically because it has not seen any activity in 90 days |
|
closing, not worked on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :class:
CTDRefDataFetcheris badly located in thedata_fetchersprivate sub-module, let's refactor in the more appropriaterelatedpublic sub-module.