Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a more sane infrastructure for included addons #166

Open
angryzor opened this issue Feb 11, 2023 · 0 comments
Open

Make a more sane infrastructure for included addons #166

angryzor opened this issue Feb 11, 2023 · 0 comments
Labels
enhancement Change to an existing feature

Comments

@angryzor
Copy link
Contributor

We have some repeated code in the attsrv api interface for dealing with addons already included in ticket levels which, combined with the special case in the addon component for this, made it clear that whether addons are selected is actually partially a derived property, and maybe shouldn't be also stored in a selected boolean for levels where they are already included.

We should think of a possible refactoring around this.
@angryzor angryzor added the enhancement Change to an existing feature label Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Change to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@angryzor