Merge pull request #833 from europeana/feat/MET-5784-Handle-Empty-Transformation-Result

MET-5785 Handle Empty Transformation Result

Author: andyjmaclean

projects/metis/cypress/e2e/mapping.cy.ts

@@ -1,4 +1,4 @@
-import { cleanupUser, setupUser } from '../support/helpers';
+import { cleanupUser, setEmptyDataResult, setupUser } from '../support/helpers';
 
 context('metis-ui', () => {
   describe('mapping', () => {
@@ -42,6 +42,23 @@ context('metis-ui', () => {
       cy.url().should('contain', '/mapping');
     });
 
+    it('should show try out XSLT (fail)', () => {
+      const selSampleEmpty = '.sample-data-empty';
+      cy.get(selSampleEmpty).should('not.exist');
+      cy.wait(1);
+
+      setEmptyDataResult(
+        '/orchestrator/proxies/records?workflowExecutionId=0&pluginType=OAIPMH_HARVEST&nextPage=',
+        true
+      );
+
+      cy.get(selBtnTryDefaultXSLT)
+        .first()
+        .click();
+
+      cy.get(selSampleEmpty).should('have.length', 1);
+    });
+
     it('should initialise an editor with the default XSLT', () => {
       cy.get(selBtnInitDefault).should('not.exist');
       cy.visit('/dataset/mapping/1');

projects/metis/cypress/support/helpers.ts

@@ -37,8 +37,11 @@ export function cleanupUser(): void {
   });
 }
 
-export function setEmptyDataResult(url: string): void {
-  url = Cypress.env('dataServer') + url + UrlManipulation.RETURN_EMPTY;
+export function setEmptyDataResult(url: string, emptyArray = false): void {
+  const manipulationType = emptyArray
+    ? UrlManipulation.RETURN_EMPTY_ARRAY
+    : UrlManipulation.RETURN_EMPTY;
+  url = Cypress.env('dataServer') + url + manipulationType;
   cy.request(url);
 }
 

projects/metis/src/app/dataset/preview/preview.component.html

@@ -4,6 +4,12 @@
   (closed)="notification = undefined"
 ></app-notification>
 
+<ng-template #sampleDataEmpty>
+  <span class="sample-data-empty">
+    There is no tranformation available
+  </span>
+</ng-template>
+
 <div *ngIf="!tempXSLT">
   <div class="filter-wrapper">
     <ul
@@ -225,7 +231,12 @@
     </div>
   </div>
 
-  <div *ngIf="allTransformedSamples && allSamples">
+  <div
+    *ngIf="
+      allTransformedSamples && allTransformedSamples.length && allSamples && allSamples.length;
+      else sampleDataEmpty
+    "
+  >
     <ng-container *ngFor="let sample of allSamples; let i = index">
       <app-editor
         [index]="i"

projects/metis/test-data/_models/test-models.ts

@@ -7,6 +7,7 @@ export enum UrlManipulation {
   RETURN_401 = 'METIS_UI_401',
   RETURN_404 = 'METIS_UI_404',
   RETURN_EMPTY = 'METIS_UI_EMPTY',
+  RETURN_EMPTY_ARRAY = 'METIS_UI_EMPTY_ARRAY',
   METIS_UI_CLEAR = 'METIS_UI_CLEAR'
 }
 

projects/metis/test-data/index.ts

@@ -26,6 +26,7 @@ const FAIL = 'fail';
 const SWITCH_TYPES = [
   UrlManipulation.RETURN_401,
   UrlManipulation.RETURN_404,
+  UrlManipulation.RETURN_EMPTY_ARRAY,
   UrlManipulation.RETURN_EMPTY
 ];
 
@@ -83,9 +84,13 @@ new (class extends TestDataServer {
   depublicationInfoCache: Array<RecordDepublicationInfo> = [];
   switchedOff: { [key: string]: string } = {};
 
-  returnEmpty(response: ServerResponse): void {
+  returnEmpty(response: ServerResponse, fmtRecords = false): void {
     response.setHeader('Content-Type', 'application/json;charset=UTF-8');
-    response.end('{ "results": [], "listSize":0, "nextPage":-1 }');
+    if (fmtRecords) {
+      response.end('{ "records":[], "nextPage": null }');
+    } else {
+      response.end('{ "results": [], "listSize":0, "nextPage":-1 }');
+    }
   }
 
   return404(response: ServerResponse, statusMessage = 'Not found'): void {
@@ -472,6 +477,7 @@ new (class extends TestDataServer {
 
     if (regRes) {
       const params = url.parse(route, true).query;
+
       response.end(
         JSON.stringify(
           executionsByDatasetIdAsList(
@@ -738,14 +744,16 @@ new (class extends TestDataServer {
 
     if (new RegExp(SWITCH_TYPES.join('|')).exec(route)) {
       this.switchOff(route);
-      this.returnEmpty(response);
+      this.returnEmpty(response, route.indexOf(UrlManipulation.RETURN_EMPTY_ARRAY) > -1);
       return;
     }
 
     const switchedOff = this.isSwitchedOff(route);
     if (switchedOff) {
       if (switchedOff === UrlManipulation.RETURN_EMPTY) {
         this.returnEmpty(response);
+      } else if (switchedOff === UrlManipulation.RETURN_EMPTY_ARRAY) {
+        this.returnEmpty(response, true);
       } else if (switchedOff === UrlManipulation.RETURN_401) {
         this.return401(response);
       } else if (switchedOff === UrlManipulation.RETURN_404) {