Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exception to non-scalar passsed to solver.optimizer #753 #789

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

exception to non-scalar passsed to solver.optimizer #753 #789

wants to merge 2 commits into from

Conversation

Sbhat92
Copy link
Contributor

@Sbhat92 Sbhat92 commented May 9, 2023 •
edited
Loading

Fixes #753 : exception to non-scalar passed to solver.optimize

@Sbhat92 Sbhat92 changed the title exception to non-scalar passsed to solver.optimizer exception to non-scalar passsed to solver.optimizer #753 May 9, 2023
gertjanvanzwieten
gertjanvanzwieten requested changes May 10, 2023
View reviewed changes
nutils/solver.py Outdated Show resolved Hide resolved
nutils/solver.py Outdated Show resolved Hide resolved
@Sbhat92
Copy link
Contributor Author

Sbhat92 commented May 11, 2023

Can I add a test case as well?

@gertjanvanzwieten
Copy link
Contributor

Can I add a test case as well?

Absolutely! I think the best place for that would be in tests/test_solver.py in the optimize class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gertjanvanzwieten gertjanvanzwieten gertjanvanzwieten requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

early and informative exception when passing a non-scalar func to solver.optimize
2 participants
@Sbhat92 @gertjanvanzwieten