Feat/skills manager (#567)

* chore(skills): move merged PR changes into feat/skills-manager

* skill installer

* SPECULATIVE

* default marketplace config

* skills manager

* fix type checkers/lint

Author: evalstate

AGENTS.md

@@ -0,0 +1,2 @@
+Present links to images and other content in Markdown links -- for example: ![Image](https://link.to.image)
+

examples/setup/fastagent.config.yaml

@@ -63,3 +63,9 @@ mcp:
       url: "https://huggingface.co/mcp?login"
       # headers:
       # "Authorization": "Bearer ${ENV_VAR}"
+
+# Skills configuration
+skills:
+  marketplace_urls:
+    - "https://github.com/huggingface/skills"
+    - "https://github.com/anthropics/skills"

publish/hf-inference-acp/src/hf_inference_acp/agents.py

@@ -216,7 +216,7 @@ def acp_mode_info(self) -> ACPModeInfo | None:
     @property
     def acp_session_commands_allowlist(self) -> set[str]:
         """Restrict built-in session commands for setup flows."""
-        return {"status"}
+        return {"status", "skills"}
 
     async def _handle_set_model(self, arguments: str) -> str:
         """Handler for /set-model command."""

publish/hf-inference-acp/src/hf_inference_acp/hf_config.py

@@ -137,14 +137,22 @@ def load_system_prompt() -> str:
 """
 
 
-def load_config() -> dict[str, Any]:
+def load_config(*, ensure_skills: bool = True) -> dict[str, Any]:
     """Load configuration from the config file.
 
+    Args:
+        ensure_skills: If True, ensure skill registries are configured for
+            existing users (adds defaults if missing). Set to False to avoid
+            recursion when called from ensure_skill_registries().
+
     Returns:
         Configuration dictionary (as ruamel.yaml CommentedMap to preserve comments)
     """
     config_path = ensure_config_exists()
 
+    if ensure_skills:
+        ensure_skill_registries()
+
     if config_path.exists():
         with open(config_path) as f:
             return _yaml.load(f) or {}
@@ -209,3 +217,47 @@ def update_mcp_server_load_on_start(server_name: str, load_on_start: bool) -> No
 
     with open(config_path, "w") as f:
         _yaml.dump(config, f)
+
+
+DEFAULT_SKILL_REGISTRIES = [
+    "https://github.com/huggingface/skills",
+    "https://github.com/anthropics/skills",
+]
+
+
+def ensure_skill_registries() -> None:
+    """Ensure skill registries are configured for existing users.
+
+    Handles config migration for users with existing config files:
+    - If skills.marketplace_urls key is missing: add default registries
+    - If skills.marketplace_urls exists (even if empty): user made an
+      intentional choice, don't override
+    """
+    config_path = ensure_config_exists()
+
+    if config_path.exists():
+        with open(config_path) as f:
+            config = _yaml.load(f) or {}
+    else:
+        return
+
+    modified = False
+
+    # Check if skills section exists
+    if "skills" not in config:
+        # Key missing entirely - add defaults
+        config["skills"] = {"marketplace_urls": list(DEFAULT_SKILL_REGISTRIES)}
+        modified = True
+    elif config["skills"] is None:
+        # skills: null - add defaults
+        config["skills"] = {"marketplace_urls": list(DEFAULT_SKILL_REGISTRIES)}
+        modified = True
+    elif "marketplace_urls" not in config["skills"]:
+        # skills section exists but marketplace_urls key is missing - add defaults
+        config["skills"]["marketplace_urls"] = list(DEFAULT_SKILL_REGISTRIES)
+        modified = True
+    # else: marketplace_urls key exists (empty or with values) - respect user's choice
+
+    if modified:
+        with open(config_path, "w") as f:
+            _yaml.dump(config, f)

publish/hf-inference-acp/src/hf_inference_acp/resources/hf.config.yaml

@@ -16,6 +16,12 @@ mcp:
       url: "https://huggingface.co/mcp"
       load_on_start: false
 
+skills:
+  marketplace_urls:
+    - "https://github.com/huggingface/skills"
+    - "https://github.com/anthropics/skills"
+
 hf:
 #  api_key: hf_xxxxxx - you can set your API key here (takes priority)
 #  default_provider: [together|cerberas|groq|etc.]
+

publish/hf-inference-acp/src/hf_inference_acp/wizard/wizard_llm.py

@@ -186,6 +186,7 @@ async def _handle_welcome(self, user_input: str) -> str:
   /login     - Get instructions for setting up your token
   /set-model - Set the default model
   /check     - Verify your configuration
+  /skills add - Install skills from the marketplace
 
 Type any command to continue.
 """
@@ -262,8 +263,10 @@ async def _handle_token_verify(self, user_input: str) -> str:
 
             # Move to model selection
             self._state.stage = WizardStage.MODEL_SELECT
-            return f"""Token verified - connected as: `{username}`
-            
+            return f"""## Step 1 - Hugging Face Token Setup
+
+Token verified - connected as: `{username}`
+
 {self._render_model_selection()}"""
         except Exception as e:
             self._state.token_verified = False
@@ -333,7 +336,7 @@ async def _handle_model_select(self, user_input: str) -> str:
         else:
             return f"Invalid selection: '{user_input}'\n\n{self._render_model_selection()}"
 
-        # Move to MCP connect step
+        # Skip skills selection step and move to MCP connection
         self._state.stage = WizardStage.MCP_CONNECT
         return self._render_mcp_connect()
 
@@ -359,11 +362,27 @@ async def _handle_mcp_connect(self, user_input: str) -> str:
         if cmd in ("y", "yes"):
             self._state.mcp_load_on_start = True
             self._state.stage = WizardStage.CONFIRM
-            return self._render_confirmation()
+            return "\n".join(
+                [
+                    "## Skills (Optional)",
+                    "",
+                    "Skills are available. Use `/skills add` to install.",
+                    "",
+                    self._render_confirmation(),
+                ]
+            )
         elif cmd in ("n", "no"):
             self._state.mcp_load_on_start = False
             self._state.stage = WizardStage.CONFIRM
-            return self._render_confirmation()
+            return "\n".join(
+                [
+                    "## Skills (Optional)",
+                    "",
+                    "Skills are available. Use `/skills add` to install.",
+                    "",
+                    self._render_confirmation(),
+                ]
+            )
         elif cmd in ("quit", "exit", "q"):
             return "Setup cancelled. Your configuration was not changed."
         else: