adding support for int type in shaders #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers at different locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a shader has a uniform of type int, an error will result (GL_INVALID_OPERATION : glUniform1fv: wrong uniform function for type) since all individual values passed to GL.Shaders.uniforms() are assumed to be floats.
I'm overloading on isSampler to make the initial decision. Note that 'isSampler' is now technically 'isIntUniform', but I'll leave that naming convention to you.
This is my first pull request, so let me know if this is helpful or what I should be doing in the future! :) Thanks for this helpful library.