-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Individual cron job runs should be marked as timed out in the cron log #261
Comments
"timeout" should probably be a separate flag from result. A task that timed out might still finish successfully, or it might fail in a particular way that matters. |
Hm. What is your expectation for what happens when something times out? I would expect a task that times out to be killed, and thus generally be a failure. |
So, we currently can't kill tasks that exceed their timeout window (at least, not in a reliable way). So we have to wait for them to finish, or not. However, we could get around this by actually moving the tasks onto individual Web Workers. Those can be terminated, but it probably makes other orchestration a bit harder. Worth some investigation. |
...or just move to an actual job management framework like Kue: https://github.com/Automattic/kue |
yeah but let's not introduce another entire database just to be able to kill cron jobs |
If a cron job run times out, currently it winds up just displaying with a yellow background (as if it were still running), and no duration / result.
It should display the duration after which it timed out, and a result of 'timeout'
The text was updated successfully, but these errors were encountered: