Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kSecClassInternetPassword class? #159

Open
jordanhbuiltbyhq opened this issue Sep 6, 2022 · 0 comments
Open

Support kSecClassInternetPassword class? #159

jordanhbuiltbyhq opened this issue Sep 6, 2022 · 0 comments

Comments

@jordanhbuiltbyhq
Copy link

jordanhbuiltbyhq commented Sep 6, 2022

Apple seems to recommend when saving a password to use kSecClassInternetPassword where you specify a username account, a server, and a password (documentation). There is a note that one should use kSecClassGenericPassword instead when you don’t need extra attributes for remote access. Now everything in this keychain library uses kSecClassGenericPassword it's not possible to use kSecClassInternetPassword.

As an aside, it's mildly interesting, I suspect basically everyone is "misusing" the keychain API because I believe the "account" is not intended to be a key to look up like "MyServicePassword", it should seemingly be the user's account like their actual username. This makes it a bit tricky to look up later and migrate when the username changes. Wishing the keychain API were nicer fr. But perhaps this library could implement support for the recommended solution and even encourage correct usage? :)

@jordanhbuiltbyhq jordanhbuiltbyhq changed the title Support kSecClassInternetPassword class Support kSecClassInternetPassword class? Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant