Skip to content

Fix possible race in user creation #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

Fix possible race in user creation #1319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions atox/src/main/kotlin/ui/createprofile/CreateProfileFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// SPDX-FileCopyrightText: 2020-2021 aTox contributors
// SPDX-FileCopyrightText: 2019-2025 Robin Lindén <[email protected]>
// SPDX-FileCopyrightText: 2022 aTox contributors
//
// SPDX-License-Identifier: GPL-3.0-only

Expand All @@ -19,6 +20,7 @@ import androidx.core.view.WindowInsetsCompat
import androidx.core.view.updatePadding
import androidx.fragment.app.viewModels
import androidx.navigation.fragment.findNavController
import kotlinx.coroutines.runBlocking
import ltd.evilcorp.atox.R
import ltd.evilcorp.atox.databinding.FragmentProfileBinding
import ltd.evilcorp.atox.ui.BaseFragment
Expand Down Expand Up @@ -95,7 +97,10 @@ class CreateProfileFragment : BaseFragment<FragmentProfileBinding>(FragmentProfi
name = if (username.text.isNotEmpty()) username.text.toString() else getString(R.string.name_default),
statusMessage = getString(R.string.status_message_default),
)
viewModel.create(user)

runBlocking {
viewModel.create(user).join()
}

findNavController().popBackStack()
}
Expand Down
Loading