fix(chat): address second round review blockers for bulk resolve (EVO-1011)

- fix(i18n): replace noPermissionSend with dedicated bulkResolveNoPermission key in all 6 locales
- fix(i18n): replace broken plural concatenation with i18next native selectedCount_one/other keys
- fix(dead-code): remove unused conversationAPI.bulkResolve from conversationService
- fix(a11y): disable bulk resolve button when user lacks conversations:update permission

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: marcelogorutuba

src/components/chat/chat-sidebar/ChatSidebar.tsx

@@ -99,6 +99,7 @@ interface ChatSidebarProps {
   onClearSelection: () => void;
   onBulkResolve: () => Promise<void>;
   isBulkResolving?: boolean;
+  canBulkResolve?: boolean;
 }
 
 const ChatSidebar = ({
@@ -128,6 +129,7 @@ const ChatSidebar = ({
   onClearSelection,
   onBulkResolve,
   isBulkResolving = false,
+  canBulkResolve = true,
 }: ChatSidebarProps) => {
   const { t } = useLanguage('chat');
   const chatContext = useChatContext();
@@ -993,11 +995,7 @@ const ChatSidebar = ({
         <div className="px-3 py-2 border-b bg-primary/5 flex flex-col gap-1.5 flex-shrink-0">
           <div className="flex items-center justify-between">
             <span className="text-sm font-medium text-muted-foreground">
-              {selectedConversationIds.size}{' '}
-              {selectedConversationIds.size === 1
-                ? t('chatSidebar.conversation')
-                : t('chatSidebar.conversations')}{' '}
-              {t('chatSidebar.selected')}
+              {t('chatSidebar.selectedCount', { count: selectedConversationIds.size })}
             </span>
             <Button
               variant="ghost"
@@ -1012,7 +1010,7 @@ const ChatSidebar = ({
             size="sm"
             className="h-7 w-full cursor-pointer"
             onClick={onBulkResolve}
-            disabled={isBulkResolving}
+            disabled={isBulkResolving || !canBulkResolve}
           >
             <CheckCircle className="h-3.5 w-3.5 mr-1.5" />
             {t('chatHeader.actions.markAsResolved')}

src/i18n/locales/en/chat.json

@@ -293,7 +293,8 @@
       "deleteConversation": "Delete conversation",
       "bulkResolveSuccess": "{{count}} conversation(s) resolved",
       "bulkResolvePartialSuccess": "{{success}} resolved, {{failed}} failed",
-      "bulkResolveError": "Error resolving conversations"
+      "bulkResolveError": "Error resolving conversations",
+      "bulkResolveNoPermission": "You do not have permission to resolve conversations"
     },
     "contactNoName": "Contact without name",
     "status": "Status:",
@@ -305,7 +306,8 @@
     "searchPlaceholder": "Search conversations...",
     "conversation": "conversation",
     "conversations": "conversations",
-    "selected": "selected",
+    "selectedCount_one": "{{count}} conversation selected",
+    "selectedCount_other": "{{count}} conversations selected",
     "selectConversation": "Select conversation",
     "filter": "filter",
     "filters": "filters",

src/i18n/locales/es/chat.json

@@ -288,7 +288,8 @@
       "deleteConversation": "Eliminar conversación",
       "bulkResolveSuccess": "{{count}} conversación(es) resuelta(s)",
       "bulkResolvePartialSuccess": "{{success}} resuelta(s), {{failed}} fallida(s)",
-      "bulkResolveError": "Error al resolver conversaciones"
+      "bulkResolveError": "Error al resolver conversaciones",
+      "bulkResolveNoPermission": "No tienes permiso para resolver conversaciones"
     },
     "contactNoName": "Contacto sin nombre",
     "status": "Estado:",
@@ -300,7 +301,8 @@
     "searchPlaceholder": "Buscar conversaciones...",
     "conversation": "conversación",
     "conversations": "conversaciones",
-    "selected": "seleccionada(s)",
+    "selectedCount_one": "{{count}} conversación seleccionada",
+    "selectedCount_other": "{{count}} conversaciones seleccionadas",
     "selectConversation": "Seleccionar conversación",
     "filter": "filtro",
     "filters": "filtros",

src/i18n/locales/fr/chat.json

@@ -288,7 +288,8 @@
       "deleteConversation": "Supprimer la conversation",
       "bulkResolveSuccess": "{{count}} conversation(s) résolue(s)",
       "bulkResolvePartialSuccess": "{{success}} résolue(s), {{failed}} échouée(s)",
-      "bulkResolveError": "Erreur lors de la résolution des conversations"
+      "bulkResolveError": "Erreur lors de la résolution des conversations",
+      "bulkResolveNoPermission": "Vous n'avez pas la permission de résoudre des conversations"
     },
     "contactNoName": "Contact sans nom",
     "status": "Statut :",
@@ -300,7 +301,8 @@
     "searchPlaceholder": "Rechercher des conversations...",
     "conversation": "conversation",
     "conversations": "conversations",
-    "selected": "sélectionnée(s)",
+    "selectedCount_one": "{{count}} conversation sélectionnée",
+    "selectedCount_other": "{{count}} conversations sélectionnées",
     "selectConversation": "Sélectionner la conversation",
     "filter": "filtre",
     "filters": "filtres",

src/i18n/locales/it/chat.json

@@ -288,7 +288,8 @@
       "deleteConversation": "Elimina conversazione",
       "bulkResolveSuccess": "{{count}} conversazione/i risolta/e",
       "bulkResolvePartialSuccess": "{{success}} risolta/e, {{failed}} fallita/e",
-      "bulkResolveError": "Errore nella risoluzione delle conversazioni"
+      "bulkResolveError": "Errore nella risoluzione delle conversazioni",
+      "bulkResolveNoPermission": "Non hai il permesso di risolvere le conversazioni"
     },
     "contactNoName": "Contatto senza nome",
     "status": "Stato:",
@@ -300,7 +301,8 @@
     "searchPlaceholder": "Cerca conversazioni...",
     "conversation": "conversazione",
     "conversations": "conversazioni",
-    "selected": "selezionata/e",
+    "selectedCount_one": "{{count}} conversazione selezionata",
+    "selectedCount_other": "{{count}} conversazioni selezionate",
     "selectConversation": "Seleziona conversazione",
     "filter": "filtro",
     "filters": "filtri",

src/i18n/locales/pt-BR/chat.json

@@ -293,7 +293,8 @@
       "deleteConversation": "Deletar conversa",
       "bulkResolveSuccess": "{{count}} conversa(s) resolvida(s)",
       "bulkResolvePartialSuccess": "{{success}} resolvida(s), {{failed}} falhada(s)",
-      "bulkResolveError": "Erro ao resolver conversas em lote"
+      "bulkResolveError": "Erro ao resolver conversas em lote",
+      "bulkResolveNoPermission": "Você não tem permissão para resolver conversas"
     },
     "contactNoName": "Contato sem nome",
     "status": "Status:",
@@ -305,7 +306,8 @@
     "searchPlaceholder": "Buscar conversas...",
     "conversation": "conversa",
     "conversations": "conversas",
-    "selected": "selecionada(s)",
+    "selectedCount_one": "{{count}} conversa selecionada",
+    "selectedCount_other": "{{count}} conversas selecionadas",
     "selectConversation": "Selecionar conversa",
     "filter": "filtro",
     "filters": "filtros",

src/i18n/locales/pt/chat.json

@@ -288,7 +288,8 @@
       "deleteConversation": "Deletar conversa",
       "bulkResolveSuccess": "{{count}} conversa(s) resolvida(s)",
       "bulkResolvePartialSuccess": "{{success}} resolvida(s), {{failed}} falhada(s)",
-      "bulkResolveError": "Erro ao resolver conversas em lote"
+      "bulkResolveError": "Erro ao resolver conversas em lote",
+      "bulkResolveNoPermission": "Não tem permissão para resolver conversas"
     },
     "contactNoName": "Contato sem nome",
     "status": "Status:",
@@ -300,7 +301,8 @@
     "searchPlaceholder": "Buscar conversas...",
     "conversation": "conversa",
     "conversations": "conversas",
-    "selected": "selecionada(s)",
+    "selectedCount_one": "{{count}} conversa selecionada",
+    "selectedCount_other": "{{count}} conversas selecionadas",
     "selectConversation": "Selecionar conversa",
     "filter": "filtro",
     "filters": "filtros",

src/pages/Customer/Chat/Chat.tsx

@@ -215,7 +215,7 @@ const Chat = () => {
   const handleBulkResolve = useCallback(async () => {
     if (selectedConversationIds.size === 0) return;
     if (!can('conversations', 'update')) {
-      toast.error(t('messages.noPermissionSend'));
+      toast.error(t('chatHeader.actions.bulkResolveNoPermission'));
       return;
     }
     const displayIds = Array.from(selectedConversationIds);
@@ -776,6 +776,7 @@ const Chat = () => {
           onClearSelection={handleClearSelection}
           onBulkResolve={handleBulkResolve}
           isBulkResolving={isBulkResolving}
+          canBulkResolve={can('conversations', 'update')}
         />
 
         {/* Chat Area */}

src/services/conversations/conversationService.ts

@@ -181,15 +181,6 @@ export const conversationAPI = {
     return extractData<any>(response);
   },
 
-  // Bulk resolve conversations by display_id
-  async bulkResolve(displayIds: string[]): Promise<void> {
-    await api.post('/bulk_actions', {
-      type: 'Conversation',
-      ids: displayIds,
-      fields: { status: 'resolved' },
-    });
-  },
-
   // Get conversation counts
   async getConversationCounts(): Promise<{
     open_count: number;