Skip to content

Commit 4ba2fed

Browse files
authored
Merge pull request #2350 from exadel-inc/tech/esl-carousel-area-rename
refactor(esl-carousel): rename `data-slides-area` container to mo obvious `esl-carousel-slides`
2 parents 30d21cc + b8772c2 commit 4ba2fed

File tree

9 files changed

+20
-20
lines changed

9 files changed

+20
-20
lines changed

site/src/esl-carousel-demo/test-carousel.less

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
}
4040

4141
&.main-carousel {
42-
div[data-slides-area] {
42+
div[esl-carousel-slides] {
4343
min-height: 500px;
4444
gap: 0;
4545
}

site/src/landing/overview/overview.less

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
position: relative;
1010
padding: 20px 40px;
1111

12-
&-scene[data-slides-area] {
12+
&-scene[esl-carousel-slides] {
1313
width: 100%;
1414
}
1515

site/views/_includes/landing/overview.njk

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<esl-carousel class="overview-carousel">
33
<button class="overview-btn-prev-wrapper" data-slide-target="prev"></button>
44

5-
<div data-slides-area class="overview-carousel-scene">
5+
<div esl-carousel-slides class="overview-carousel-scene">
66
<esl-carousel-slide active class="overview-carousel-item">
77
<div class="overview-item">
88
<div class="overview-illustration">

site/views/examples/carousel.marquee.njk

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ icon: examples/carousel.svg
1313
type="default"
1414
esl-carousel-touch
1515
esl-carousel-relate-to="#nav-carousel">
16-
<div data-slides-area>
16+
<div esl-carousel-slides>
1717
{% for item in slides %}
1818
<esl-carousel-slide>
1919
<div class="img-container">
@@ -35,7 +35,7 @@ icon: examples/carousel.svg
3535
esl-carousel-touch
3636
type="default"
3737
count="5">
38-
<div data-slides-area>
38+
<div esl-carousel-slides>
3939
{% for item in slides %}
4040
<esl-carousel-slide>
4141
<div class="img-container img-container-4-3"

site/views/examples/carousel.njk

+5-5
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ icon: examples/carousel.svg
1919
media="@XS|@SM|@MD|@LG|@XL"
2020
loop="true"
2121
count="1|2|3|4|5">
22-
<div data-slides-area>
22+
<div esl-carousel-slides>
2323
{% for item in cards %}
2424
<esl-carousel-slide {{ 'active' if loop.first }}>
2525
<div class="card">
@@ -59,7 +59,7 @@ icon: examples/carousel.svg
5959
esl-carousel-touch
6060
count="2"
6161
loop="true">
62-
<div data-slides-area>
62+
<div esl-carousel-slides>
6363
{% for i in range(0, 6) -%}
6464
<esl-carousel-slide style="max-width: 50%">
6565
<div class="card">
@@ -91,7 +91,7 @@ icon: examples/carousel.svg
9191
media="@XS|@SM|@MD|@LG|@XL"
9292
count="2|3|4|5|6"
9393
loop="true">
94-
<div data-slides-area>
94+
<div esl-carousel-slides>
9595
{% for item in items %}
9696
<esl-carousel-slide {{ 'active' if loop.first }}>
9797
<div class="card" style="justify-content: center; background: {{item.background}}">
@@ -121,7 +121,7 @@ icon: examples/carousel.svg
121121
<esl-carousel esl-carousel-touch="none | @XS => drag"
122122
media="@XS|@SM|@MD|@LG|@XL"
123123
count="2|3|4|5|6">
124-
<div data-slides-area>
124+
<div esl-carousel-slides>
125125
{% for item in items %}
126126
<esl-carousel-slide {{ 'active' if loop.first }}>
127127
<div class="card" style="justify-content: center; background: {{item.background}}">
@@ -149,7 +149,7 @@ icon: examples/carousel.svg
149149
</button>
150150

151151
<esl-carousel esl-carousel-touch="@touch => swipe" loop="true">
152-
<div data-slides-area>
152+
<div esl-carousel-slides>
153153
{% for i in range(0, 4) -%}
154154
<esl-carousel-slide>
155155
<div class="card">

src/modules/esl-carousel/core/esl-carousel.less

+5-5
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ esl-carousel {
1212
/* stylelint-disable-next-line */
1313
overflow: clip;
1414

15-
[data-slides-area] {
15+
[esl-carousel-slides] {
1616
position: relative;
1717
width: 100%;
1818
display: flex;
@@ -21,19 +21,19 @@ esl-carousel {
2121
transform: translate3d(0px, 0px, 0px);
2222
}
2323

24-
&.esl-carousel-vertical [data-slides-area] {
24+
&.esl-carousel-vertical [esl-carousel-slides] {
2525
flex-direction: column;
2626
}
27-
&.esl-carousel-horizontal [data-slides-area] {
27+
&.esl-carousel-horizontal [esl-carousel-slides] {
2828
flex-direction: row;
2929
}
3030

3131
&[dragging] {
3232
cursor: grabbing;
3333
}
3434

35-
&[dragging] [data-slides-area],
36-
&[animating] [data-slides-area] {
35+
&[dragging] [esl-carousel-slides],
36+
&[animating] [esl-carousel-slides] {
3737
user-select: none;
3838
touch-action: pan-y;
3939
pointer-events: none;

src/modules/esl-carousel/core/esl-carousel.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,10 @@ export class ESLCarousel extends ESLBaseElement {
211211
/** @returns carousel slides area */
212212
@memoize()
213213
public get $slidesArea(): HTMLElement {
214-
const $provided = this.querySelector('[data-slides-area]');
214+
const $provided = this.querySelector('[esl-carousel-slides]');
215215
if ($provided) return $provided as HTMLElement;
216216
const $container = document.createElement('div');
217-
$container.setAttribute('data-slides-area', '');
217+
$container.setAttribute('esl-carousel-slides', '');
218218
this.appendChild($container);
219219
return $container ;
220220
}

src/modules/esl-carousel/plugin/dots/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Example:
99
```html
1010
<esl-carousel-slide esl-carousel-container>
1111
<esl-carousel count="1">
12-
<div data-slides-area>
12+
<div esl-carousel-slides>
1313
<esl-carousel-slide>Slide 1</esl-carousel-slide>
1414
<esl-carousel-slide>Slide 2</esl-carousel-slide>
1515
<esl-carousel-slide>Slide 3</esl-carousel-slide>

src/modules/esl-carousel/renderers/esl-carousel.default.renderer.less

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
.esl-carousel-default-renderer {
2-
[data-slides-area] {
2+
[esl-carousel-slides] {
33
display: flex;
44
flex-wrap: nowrap;
55
transition: none;
66
max-width: 100%;
77
max-height: 100%;
88
}
99

10-
&[animating] [data-slides-area] {
10+
&[animating] [esl-carousel-slides] {
1111
transition: transform 0.25s linear;
1212
}
1313

0 commit comments

Comments
 (0)