Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀esl-panel-group]: (Proposal) ability to fix the height of the group to the max tab size instead of animating it #1949

Closed
ala-n opened this issue Sep 24, 2023 · 2 comments · Fixed by #2060
Assignees
Labels

Comments

@ala-n
Copy link
Collaborator

ala-n commented Sep 24, 2023

As an ESL consumer, I want to be able to make consistent height tab behavior.

Open questions:

  1. Discover the technical ways to achieve declared behavior
  2. Is it relevant to use esl-panel-group to do that? (it sounds like yes, but it doesn't sound good to overcomplicate it)
@ala-n ala-n self-assigned this Sep 24, 2023
@ala-n ala-n added this to the ⚡ESL: 4.14.0 Minor release milestone Nov 7, 2023
@ala-n ala-n added the feature New feature label Nov 7, 2023
@ala-n
Copy link
Collaborator Author

ala-n commented Nov 14, 2023

  • esl-tabs-same-height (1 +1 +2 +1 +2)
  • esl-tabs-equal-height ( +1 +2 +2 +2 +3)
  • esl-tabs-match-height ( +2 +2 +1 +1)

Final (after discussion): esl-tabs-equal-height

ala-n added a commit that referenced this issue Nov 20, 2023
…r tabs height using `esl-tabs-equal-height` class

Closes: #1949
ala-n pushed a commit that referenced this issue Nov 24, 2023
# [4.14.0](v4.13.1...v4.14.0) (2023-11-24)

### Bug Fixes

* **esl-scrollbar:** fix esl:change:scroll event handler invoked before scrollbar updates ([0c9c952](0c9c952))
* **esl-share:** add support types for correct using in Typesript ([143d3b6](143d3b6))
* **esl-share:** fix a visual issue of displaying a huge list of buttons in a popup ([a2ce0a9](a2ce0a9))
* **esl-share:** fix button initialization on create ([72775f6](72775f6))
* **esl-share:** fix ESLShareConfig deduplication behavior on selecting buttons for the list ([fe0d53a](fe0d53a))
* **esl-share:** fix ready state attribute and ready state event ([3c3dade](3c3dade))
* **esl-share:** make list an observable attribute ([f418820](f418820))
* **esl-tabs:** fix iOS auto-scroll / arrow controls boundaries on iOS devices when touch-scroll is enabled ([5845c3a](5845c3a)), closes [#2030](#2030)

### Features

* **esl-panel-group:** add ability to enable match-height behavior for tabs height using `esl-tabs-equal-height` class ([6e0ea33](6e0ea33)), closes [#1949](#1949)
* **esl-popup:** internal ESLPopup implementation updated to use ESLEventListeners; usage of cached properties reduced ([9c78249](9c78249))
* **esl-random-text:** create auxiliary `esl-random-text` component to generate dummy text ([0af54a1](0af54a1))
* **esl-share:** rename attribute into popup-params ([f07b471](f07b471))
* **esl-share:** retire esl-share and rename esl-share-popup-trigger into esl-share ([04baf4b](04baf4b))
* **esl-toggleable:** introduce static option `DEFAULT_PARAMS` to define toggleable instance default show/hide params ([14c9e78](14c9e78))
* **esl-tooltip:** add inlineStyles param to pass styles into shared instance of tooltip ([7b28cf8](7b28cf8))
* **esl-utils:** introducing `parseCSSTime` format utility to extract time values from CSS ([#821](#821)) ([d26c96e](d26c96e))
* **eslint:** eslint plugin to find and replace deprecated ESL alias on the customer's projects ([#1374](#1374)) ([3d43f92](3d43f92))
@ala-n
Copy link
Collaborator Author

ala-n commented Nov 24, 2023

🎉 This issue has been resolved in version 4.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant