Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[esl-carousel] replace default arrow implementation with a clip-path #2333

Closed
ala-n opened this issue Apr 10, 2024 · 1 comment · Fixed by #2368
Closed

[esl-carousel] replace default arrow implementation with a clip-path #2333

ala-n opened this issue Apr 10, 2024 · 1 comment · Fixed by #2368
Assignees
@NastaLeo
Labels
enhancement Improvements and additions to code released
Milestone
⚡ESL: 5.0.0 Major...

Comments

@ala-n
Copy link
Collaborator

ala-n commented Apr 10, 2024

Using clip-path to render arrows is shorter. In this case, carousel consumers can also easily change the color of the arrows depending on the carousel's state.

Originally posted by @dshovchko in #2185 (comment)
@ala-n ala-n mentioned this issue Apr 24, 2024
Merged
@ala-n ala-n linked a pull request Apr 24, 2024 that will close this issue
refactor(esl-carousel): replace default arrow implementation with a clip-path #2368
Merged
@ala-n ala-n added the enhancement Improvements and additions to code label Apr 24, 2024
@ala-n ala-n added this to the ⚡ESL: 5.0.0 Major release milestone Apr 24, 2024
@ala-n
Copy link
Collaborator Author

ala-n commented Apr 29, 2024

🎉 This issue has been resolved in version 5.0.0-beta.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NastaLeo NastaLeo

Labels
enhancement Improvements and additions to code released
Projects
None yet
Milestone
⚡ESL: 5.0.0 Major release
Development

Successfully merging a pull request may close this issue.

refactor(esl-carousel): replace default arrow implementation with a clip-path exadel-inc/esl
2 participants
@ala-n @NastaLeo